Re: [zones-discuss] reviews for 6933462 onu should support zones

2010-03-10 Thread Edward Pilatowicz
On Wed, Mar 10, 2010 at 06:56:39PM +, John Levon wrote:
> On Wed, Mar 10, 2010 at 10:46:36AM -0800, Edward Pilatowicz wrote:
>
> > > > > > > > > http://cr.opensolaris.org/~johnlev/onu-zones/
> >
> > zoneadm list -cip will only list zones in the installed state, but
>
> That's not true:
>
> r...@hiss:~# zoneadm list -cip
> 0:global:running:/::ipkg:shared
> -:ozone:installed:/rpool/zones/ozone:84452639-6108-c6e3-b411-f53b9a16cc9f:ipkg:shared
> -:twilight:configured:/rock/zones/twilight::ipkg:shared
>
> I could make it be zoneadm list -cp if it's an issue for you...
>

oops. my bad. re-reading of the man page has set me strait.
i'm fine with either cip or cp.
ed
___
zones-discuss mailing list
zones-discuss@opensolaris.org


Re: [zones-discuss] reviews for 6933462 onu should support zones

2010-03-10 Thread John Levon
On Wed, Mar 10, 2010 at 10:46:36AM -0800, Edward Pilatowicz wrote:

> > > > > > > > http://cr.opensolaris.org/~johnlev/onu-zones/
> 
> zoneadm list -cip will only list zones in the installed state, but

That's not true:

r...@hiss:~# zoneadm list -cip
0:global:running:/::ipkg:shared
-:ozone:installed:/rpool/zones/ozone:84452639-6108-c6e3-b411-f53b9a16cc9f:ipkg:shared
-:twilight:configured:/rock/zones/twilight::ipkg:shared

I could make it be zoneadm list -cp if it's an issue for you...

regards
john
___
zones-discuss mailing list
zones-discuss@opensolaris.org


Re: [zones-discuss] reviews for 6933462 onu should support zones

2010-03-10 Thread Edward Pilatowicz
On Wed, Mar 10, 2010 at 06:10:43PM +, John Levon wrote:
> On Wed, Mar 10, 2010 at 07:55:21AM -0800, Edward Pilatowicz wrote:
>
> > > > > > > http://cr.opensolaris.org/~johnlev/onu-zones/
>
> OK please reload.
>

zoneadm list -cip will only list zones in the installed state, but
update_zone() also check for the configured state.  you probably want
list -cvp

ed
___
zones-discuss mailing list
zones-discuss@opensolaris.org


Re: [zones-discuss] reviews for 6933462 onu should support zones

2010-03-10 Thread John Levon
On Wed, Mar 10, 2010 at 07:55:21AM -0800, Edward Pilatowicz wrote:

> > > > > > http://cr.opensolaris.org/~johnlev/onu-zones/

OK please reload.

regards
john
___
zones-discuss mailing list
zones-discuss@opensolaris.org


Re: [zones-discuss] reviews for 6933462 onu should support zones

2010-03-10 Thread Edward Pilatowicz
On Wed, Mar 10, 2010 at 03:52:31PM +, John Levon wrote:
> On Wed, Mar 10, 2010 at 07:40:36AM -0800, Edward Pilatowicz wrote:
>
> > > > > http://cr.opensolaris.org/~johnlev/onu-zones/
>
> Updated
>
> > hm.  i actually think we'd be ok with just cloning running zones.  we
> > after all, we don't shut down the global zone to clone it.  i guess the
> > main thing that you're protecting yourself against by shutting down the
> > zone is against there being a pkg(1) process running within the zone at
> > the time you clone it.
>
> Right. I'd kind of presumed that beadm had something similarly safe for
> the GZ, but maybe it doesn't.
>
> I don't mind removing the shutdown if people aren't wild about it.
>

personally, i'd leave it out.  onu is for developers.  if developers are
running pkg commands in an ngz while running onu at the same time in the
gz, well, don't do that.

ed
___
zones-discuss mailing list
zones-discuss@opensolaris.org


Re: [zones-discuss] reviews for 6933462 onu should support zones

2010-03-10 Thread John Levon
On Wed, Mar 10, 2010 at 07:40:36AM -0800, Edward Pilatowicz wrote:

> > > > http://cr.opensolaris.org/~johnlev/onu-zones/

Updated

> hm.  i actually think we'd be ok with just cloning running zones.  we
> after all, we don't shut down the global zone to clone it.  i guess the
> main thing that you're protecting yourself against by shutting down the
> zone is against there being a pkg(1) process running within the zone at
> the time you clone it.

Right. I'd kind of presumed that beadm had something similarly safe for
the GZ, but maybe it doesn't.

I don't mind removing the shutdown if people aren't wild about it.

regards
john
___
zones-discuss mailing list
zones-discuss@opensolaris.org


Re: [zones-discuss] reviews for 6933462 onu should support zones

2010-03-10 Thread Edward Pilatowicz
On Wed, Mar 10, 2010 at 03:13:48AM +, John Levon wrote:
> On Tue, Mar 09, 2010 at 04:36:41PM -0800, Edward Pilatowicz wrote:
>
> > > Please can I get people to take a look at:
> > >
> > > http://cr.opensolaris.org/~johnlev/onu-zones/
> >
> > i only have one comment.  is it really possible to have a zone running
> > within an alternate BE?  i didn't think it was.
>
> Hmm. I haven't done the right thing here. What I was really trying to
> say was that the zone needs to be shutdown before we clone, but of
> course that happens before we iterate through the zones. I need a
> two-pass approach...
>

hm.  i actually think we'd be ok with just cloning running zones.  we
after all, we don't shut down the global zone to clone it.  i guess the
main thing that you're protecting yourself against by shutting down the
zone is against there being a pkg(1) process running within the zone at
the time you clone it.

ed
___
zones-discuss mailing list
zones-discuss@opensolaris.org


Re: [zones-discuss] reviews for 6933462 onu should support zones

2010-03-09 Thread John Levon
On Tue, Mar 09, 2010 at 04:36:41PM -0800, Edward Pilatowicz wrote:

> > Please can I get people to take a look at:
> >
> > http://cr.opensolaris.org/~johnlev/onu-zones/
> 
> i only have one comment.  is it really possible to have a zone running
> within an alternate BE?  i didn't think it was.

Hmm. I haven't done the right thing here. What I was really trying to
say was that the zone needs to be shutdown before we clone, but of
course that happens before we iterate through the zones. I need a
two-pass approach...

regards
john
___
zones-discuss mailing list
zones-discuss@opensolaris.org


Re: [zones-discuss] reviews for 6933462 onu should support zones

2010-03-09 Thread Edward Pilatowicz
On Tue, Mar 09, 2010 at 11:12:21PM +, John Levon wrote:
>
> Please can I get people to take a look at:
>
> http://cr.opensolaris.org/~johnlev/onu-zones/
>

i only have one comment.  is it really possible to have a zone running
within an alternate BE?  i didn't think it was.

ed
___
zones-discuss mailing list
zones-discuss@opensolaris.org


Re: [zones-discuss] reviews for 6933462 onu should support zones

2010-03-09 Thread John Levon
On Tue, Mar 09, 2010 at 04:22:56PM -0800, Liane Praza wrote:

> >>http://cr.opensolaris.org/~johnlev/onu-zones/

I updated this for two jbeck comments: a spelling fix for en_US, and to
loop waiting for zones that are shutting down.

> This looks reasonable to me.  Thank you very much for tackling it.  As a
> sanity check, this probably would stay (modulo changing the messaging)
> even once upgrade-on-attach works for systems without entire, right?  It
> seems like it would be a useful developer convenience?

Yes, I expect so. Although it would be nice to be able to use
upgrade-on-attach in the new BE, I don't think that's planned.

> >the full refresh is needed because we may not have the latest
> >catalogs for all the configured publishers.
> >
> >what i tried to ask was: why don't the other set-publisher
> >operations use the --no-refresh option.  afaik, by default a
> >set-publisher operation will cause us to refresh the cached publisher
> >data, which we're going to cache anyway when we do the refresh
> >--full.
> 
> Prior to integration, we couldn't require a recent enough version of pkg 
> to count on this behaviour.  I think we do now, and this sounds like 
> it'd speed things up a little.

I filed:

6933504 onu could skip some refresh operations

thanks
john
___
zones-discuss mailing list
zones-discuss@opensolaris.org


Re: [zones-discuss] reviews for 6933462 onu should support zones

2010-03-09 Thread Liane Praza

On 03/ 9/10 03:53 PM, Edward Pilatowicz wrote:

On Tue, Mar 09, 2010 at 11:12:21PM +, John Levon wrote:


Please can I get people to take a look at:

http://cr.opensolaris.org/~johnlev/onu-zones/



This looks reasonable to me.  Thank you very much for tackling it.  As a
sanity check, this probably would stay (modulo changing the messaging)
even once upgrade-on-attach works for systems without entire, right?  It
seems like it would be a useful developer convenience?



BTW Ed was asking why the full refresh was needed - anyone?



that's not entirely true.  ;)

the full refresh is needed because we may not have the latest
catalogs for all the configured publishers.

what i tried to ask was: why don't the other set-publisher
operations use the --no-refresh option.  afaik, by default a
set-publisher operation will cause us to refresh the cached publisher
data, which we're going to cache anyway when we do the refresh
--full.


Prior to integration, we couldn't require a recent enough version of pkg 
to count on this behaviour.  I think we do now, and this sounds like 
it'd speed things up a little.


liane
___
zones-discuss mailing list
zones-discuss@opensolaris.org


Re: [zones-discuss] reviews for 6933462 onu should support zones

2010-03-09 Thread Edward Pilatowicz
On Tue, Mar 09, 2010 at 11:12:21PM +, John Levon wrote:
>
> Please can I get people to take a look at:
>
> http://cr.opensolaris.org/~johnlev/onu-zones/
>
> BTW Ed was asking why the full refresh was needed - anyone?
>

that's not entirely true.  ;)

the full refresh is needed because we may not have the latest catalogs
for all the configured publishers.

what i tried to ask was: why don't the other set-publisher operations
use the --no-refresh option.  afaik, by default a set-publisher
operation will cause us to refresh the cached publisher data, which
we're going to cache anyway when we do the refresh --full.

ed
___
zones-discuss mailing list
zones-discuss@opensolaris.org


Re: [zones-discuss] reviews for 6933462 onu should support zones

2010-03-09 Thread Peter Memishian

 > '...' substitutions won't be in POSIX anymore.

That may be, but we would have to absolutely hate our customers to remove
support for this construct from our shells, so the positions of POSIX on
the matter seem a bit academic.

--
meem
___
zones-discuss mailing list
zones-discuss@opensolaris.org


Re: [zones-discuss] reviews for 6933462 onu should support zones

2010-03-09 Thread ольга крыжановская
I would be delighted if onu.sh gets a makefile target which tests the
script with ksh93 -n for errors:
ksh93 -n onu.sh
onu.sh: warning: line 153: `...` obsolete, use $(...)
onu.sh: warning: line 203: `...` obsolete, use $(...)
onu.sh: warning: line 216: `...` obsolete, use $(...)
onu.sh: warning: line 217: `...` obsolete, use $(...)
onu.sh: warning: line 222: `...` obsolete, use $(...)
onu.sh: warning: line 237: `...` obsolete, use $(...)
onu.sh: warning: line 262: `...` obsolete, use $(...)

'...' substitutions won't be in POSIX anymore.

Olga

On Wed, Mar 10, 2010 at 12:12 AM, John Levon  wrote:
>
> Please can I get people to take a look at:
>
> http://cr.opensolaris.org/~johnlev/onu-zones/
>
> BTW Ed was asking why the full refresh was needed - anyone?
>
> thanks
> john
> ___
> zones-discuss mailing list
> zones-discuss@opensolaris.org
>



-- 
  ,   __   ,
 { \/`o;-Olga Kryzhanovska   -;o`\/ }
.'-/`-/ olga.kryzhanov...@gmail.com   \-`\-'.
 `'-..-| / Solaris/BSD//C/C++ programmer   \ |-..-'`
  /\/\ /\/\
  `--`  `--`
___
zones-discuss mailing list
zones-discuss@opensolaris.org


[zones-discuss] reviews for 6933462 onu should support zones

2010-03-09 Thread John Levon

Please can I get people to take a look at:

http://cr.opensolaris.org/~johnlev/onu-zones/

BTW Ed was asking why the full refresh was needed - anyone?

thanks
john
___
zones-discuss mailing list
zones-discuss@opensolaris.org