Heisenbugs, Bohrbugs, Mandelbugs?

2010-10-21 Thread Thomas Koch
Hi, last night I let my hudson server do 42 (sic) builds of ZooKeeper trunk. One of this builds failed: junit.framework.AssertionFailedError: Leader hasn't joined: 5 at org.apache.zookeeper.test.FLETest.testLE(FLETest.java:312) I did this many builds of trunk, because in my quest to

Re: Restarting discussion on ZooKeeper as a TLP

2010-10-21 Thread Flavio Junqueira
+1 for moving forward, and I was wondering if you have an idea of when you'd have a draft of the proposal. It would be good to iterate over it perhaps.-FlavioOn Oct 20, 2010, at 7:50 PM, Patrick Hunt wrote:It's been a few days, any thoughts? Acceptable? I'd like to keep moving theball forward.

[jira] Commented: (ZOOKEEPER-102) Need to replace Jute with supported code

2010-10-21 Thread Thomas Koch (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923380#action_12923380 ] Thomas Koch commented on ZOOKEEPER-102: --- Another option would be avro. Does

[jira] Created: (ZOOKEEPER-908) Remove code duplication and inconsistent naming in ClientCnxn.Packet creation

2010-10-21 Thread Thomas Koch (JIRA)
Remove code duplication and inconsistent naming in ClientCnxn.Packet creation - Key: ZOOKEEPER-908 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-908 Project: Zookeeper

[jira] Commented: (ZOOKEEPER-794) Callbacks are not invoked when the client is closed

2010-10-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923396#action_12923396 ] Hudson commented on ZOOKEEPER-794: -- Integrated in ZooKeeper-trunk #975 (See

[jira] Updated: (ZOOKEEPER-908) Remove code duplication and inconsistent naming in ClientCnxn.Packet creation

2010-10-21 Thread Thomas Koch (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-908: -- Attachment: ZOOKEEPER-908.patch ant test-core did work without failures. Remove code

[jira] Assigned: (ZOOKEEPER-815) fill in TBDs in overview doc

2010-10-21 Thread Andrei Savu (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Savu reassigned ZOOKEEPER-815: - Assignee: (was: Andrei Savu) fill in TBDs in overview doc

[jira] Commented: (ZOOKEEPER-906) Improve C client connection reliability by making it sleep between reconnect attempts as in Java Client

2010-10-21 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923431#action_12923431 ] Jared Cantwell commented on ZOOKEEPER-906: -- Some other small comments based on

[jira] Created: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

2010-10-21 Thread Thomas Koch (JIRA)
Extract NIO specific code from ClientCnxn - Key: ZOOKEEPER-909 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-909 Project: Zookeeper Issue Type: Sub-task Components: java client

[jira] Updated: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

2010-10-21 Thread Thomas Koch (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-909: -- Attachment: ZOOKEEPER-909.patch Extract NIO specific code from ClientCnxn

[jira] Updated: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

2010-10-21 Thread Thomas Koch (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-909: -- Status: Patch Available (was: Open) Extract NIO specific code from ClientCnxn

[jira] Created: (ZOOKEEPER-910) Use SelectionKey.isXYZ() methods instead of complicated binary logic

2010-10-21 Thread Thomas Koch (JIRA)
Use SelectionKey.isXYZ() methods instead of complicated binary logic Key: ZOOKEEPER-910 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-910 Project: Zookeeper Issue

What's the magic behind lenBuffer and incomingBuffer?

2010-10-21 Thread Thomas Koch
Hi, inside ClientCnxn.SendThread we have final ByteBuffer lenBuffer = ByteBuffer.allocateDirect(4); ByteBuffer incomingBuffer = lenBuffer; So incomingBuffer and lenBuffer do refer to the same object. There are several other places where lenBuffer is again assigned to incomingBuffer.

[jira] Created: (ZOOKEEPER-911) move operations from methods to individual classes

2010-10-21 Thread Thomas Koch (JIRA)
move operations from methods to individual classes -- Key: ZOOKEEPER-911 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-911 Project: Zookeeper Issue Type: New Feature

[jira] Commented: (ZOOKEEPER-835) Refactoring Zookeeper Client Code

2010-10-21 Thread Thomas Koch (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923476#action_12923476 ] Thomas Koch commented on ZOOKEEPER-835: --- Hi Benjamin, I'm sorry, I should have

[jira] Updated: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

2010-10-21 Thread Thomas Koch (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-909: -- Description: This patch is mostly the same patch as my last one for ZOOKEEPER-823 minus

Re: Heisenbugs, Bohrbugs, Mandelbugs?

2010-10-21 Thread Patrick Hunt
On Wed, Oct 20, 2010 at 11:48 PM, Thomas Koch tho...@koch.ro wrote: Hi, last night I let my hudson server do 42 (sic) builds of ZooKeeper trunk. One of this builds failed: junit.framework.AssertionFailedError: Leader hasn't joined: 5 at

[jira] Commented: (ZOOKEEPER-102) Need to replace Jute with supported code

2010-10-21 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923516#action_12923516 ] Doug Cutting commented on ZOOKEEPER-102: Avro is not wire-compatible with Jute.

[jira] Commented: (ZOOKEEPER-102) Need to replace Jute with supported code

2010-10-21 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923519#action_12923519 ] Patrick Hunt commented on ZOOKEEPER-102: bq. avro is wire compatible with jute?

[jira] Commented: (ZOOKEEPER-102) Need to replace Jute with supported code

2010-10-21 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923521#action_12923521 ] Patrick Hunt commented on ZOOKEEPER-102: haha, doug and I crossed beams on

[jira] Commented: (ZOOKEEPER-908) Remove code duplication and inconsistent naming in ClientCnxn.Packet creation

2010-10-21 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923526#action_12923526 ] Patrick Hunt commented on ZOOKEEPER-908: Thanks Thomas. As we are refactoring

[jira] Updated: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

2010-10-21 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-909: --- Assignee: Thomas Koch (was: Patrick Hunt) Extract NIO specific code from ClientCnxn

[jira] Updated: (ZOOKEEPER-910) Use SelectionKey.isXYZ() methods instead of complicated binary logic

2010-10-21 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-910: --- Component/s: server Assignee: Thomas Koch Thomas, feel free to make this change

[jira] Updated: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

2010-10-21 Thread Thomas Koch (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-909: -- Attachment: ZOOKEEPER-909.patch netty2 could not be found by ivy --- a/ivysettings.xml +++

Re: Restarting discussion on ZooKeeper as a TLP

2010-10-21 Thread Henry Robinson
Looks good, please do call a vote. On 21 October 2010 09:29, Patrick Hunt ph...@apache.org wrote: Here's a draft board resolution (not a vote, just discussion). It lists all current committers (except as noted in the next paragraph) as the initial members of the project management committee

[jira] Assigned: (ZOOKEEPER-904) super digest is not actually acting as a full superuser

2010-10-21 Thread Camille Fournier (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Camille Fournier reassigned ZOOKEEPER-904: -- Assignee: Camille Fournier super digest is not actually acting as a full

[jira] Updated: (ZOOKEEPER-906) Improve C client connection reliability by making it sleep between reconnect attempts as in Java Client

2010-10-21 Thread Radu Marin (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Marin updated ZOOKEEPER-906: - Attachment: ZOOKEEPER-906.patch Removed mt_adaptor.c changes. Refactored the code based on

[jira] Updated: (ZOOKEEPER-906) Improve C client connection reliability by making it sleep between reconnect attempts as in Java Client

2010-10-21 Thread Radu Marin (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Marin updated ZOOKEEPER-906: - Attachment: (was: ZOOKEEPER-906.patch) Improve C client connection reliability by making

Re: Restarting discussion on ZooKeeper as a TLP

2010-10-21 Thread Patrick Hunt
Ack, I missed Henry in the list, sorry! In my defense I copied this: http://hadoop.apache.org/zookeeper/credits.html one more try (same as before except for adding henry to the pmc): X. Establish the Apache ZooKeeper Project WHEREAS, the Board of Directors deems it to be

Re: Restarting discussion on ZooKeeper as a TLP

2010-10-21 Thread Henry Robinson
Ha, I may just have excluded myself from eligibility due to my inability to read :) On 21 October 2010 13:28, Patrick Hunt ph...@apache.org wrote: Ack, I missed Henry in the list, sorry! In my defense I copied this: http://hadoop.apache.org/zookeeper/credits.html one more try (same as before

Re: Restarting discussion on ZooKeeper as a TLP

2010-10-21 Thread Mahadev Konar
NOW, THEREFORE, BE IT FURTHER RESOLVED, that Matt Massie be appointed to the office of Vice President, Apache ZooKeeper, to I think you meant Patrick Hunt ? :) Other than that it looks good. Thanks mahadev On 10/21/10 1:28 PM, Patrick Hunt ph...@apache.org wrote: Ack, I missed

[jira] Commented: (ZOOKEEPER-907) Spurious KeeperErrorCode = Session moved messages

2010-10-21 Thread Vishal K (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923627#action_12923627 ] Vishal K commented on ZOOKEEPER-907: Ben, What do you mean by partial sync? Will

[jira] Updated: (ZOOKEEPER-800) zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE

2010-10-21 Thread Mahadev konar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-800: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch

Re: Restarting discussion on ZooKeeper as a TLP

2010-10-21 Thread Patrick Hunt
Damn, not sure how that happened. Had it right originally, one undo too many? weird. Give this one a try (henry added, chair back as expected): X. Establish the Apache ZooKeeper Project WHEREAS, the Board of Directors deems it to be in the best interests of the

Re: Restarting discussion on ZooKeeper as a TLP

2010-10-21 Thread Benjamin Reed
i think we want to be responsible for the creation and maintenance of software related to distributed system coordination. ben On 10/21/2010 01:43 PM, Mahadev Konar wrote: NOW, THEREFORE, BE IT FURTHER RESOLVED, that Matt Massie be appointed to the office of Vice President, Apache

Re: What's the magic behind lenBuffer and incomingBuffer?

2010-10-21 Thread Benjamin Reed
look in readLength(). incomingBuffer is set to a newly allocated ByteBuffer. ben On 10/21/2010 07:52 AM, Thomas Koch wrote: Hi, inside ClientCnxn.SendThread we have final ByteBuffer lenBuffer = ByteBuffer.allocateDirect(4); ByteBuffer incomingBuffer = lenBuffer; So

[jira] Updated: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

2010-10-21 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-909: --- Status: Patch Available (was: Open) Extract NIO specific code from ClientCnxn