[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930544#action_12930544 ] Thomas Koch commented on ZOOKEEPER-909: --- Dear Hudson, you're terribly annoying

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930546#action_12930546 ] Flavio Junqueira commented on ZOOKEEPER-909: Thomas, Check the console

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930548#action_12930548 ] Patrick Hunt commented on ZOOKEEPER-909: Hi Thomas. Still shaky legs on getting

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930552#action_12930552 ] Hadoop QA commented on ZOOKEEPER-909: - -1 overall. Here are the results of testing

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930553#action_12930553 ] Patrick Hunt commented on ZOOKEEPER-909: better, but why is javadoc failing for

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930558#action_12930558 ] Thomas Koch commented on ZOOKEEPER-909: --- In our build.xml we still have the old

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930574#action_12930574 ] Hadoop QA commented on ZOOKEEPER-909: - +1 overall. Here are the results of testing

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930821#action_12930821 ] Hudson commented on ZOOKEEPER-909: -- Integrated in ZooKeeper-trunk #997 (See

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930074#action_12930074 ] Thomas Koch commented on ZOOKEEPER-909: --- 3 out of 3 test runs did pass (as

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930195#action_12930195 ] Patrick Hunt commented on ZOOKEEPER-909: Hi Thomas, thanks! One more request,

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12930440#action_12930440 ] Hadoop QA commented on ZOOKEEPER-909: - -1 overall. Here are the results of testing

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12929395#action_12929395 ] Thomas Koch commented on ZOOKEEPER-909: --- I've added some javadoc and renamed

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12927710#action_12927710 ] Jacob Levy commented on ZOOKEEPER-909: -- Some questions after reviewing your diff

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12927045#action_12927045 ] Benjamin Reed commented on ZOOKEEPER-909: - the patch looks good. are you

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923779#action_12923779 ] Patrick Hunt commented on ZOOKEEPER-909: I ran the tests on my own test harness

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923905#action_12923905 ] Benjamin Reed commented on ZOOKEEPER-909: - this is looking really nice. i'm not

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923975#action_12923975 ] Patrick Hunt commented on ZOOKEEPER-909: Thomas, I assigned the jira to you

[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn

[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923986#action_12923986 ] Thomas Koch commented on ZOOKEEPER-909: --- Hi Benjamin, you mean, I should add a