Re: [Zope-CMF] [dev] CMFDefault: renaming type action urls
Am 21.05.2013, 12:34 Uhr, schrieb yuppie : Yes. Default view and 'view' are identical for other content types, but File and Image have a download view and a preview. Okay. Otherwise it's a very sensible clean up of a wart of the old style Meanwhile this is checked in. But if there are no objections I'd like to make a small modification: We have 'view' (not 'viewing') and 'edit' (not 'editing'), so I think we should use 'share' instead of 'sharing' for local roles. Fine with me. Charlie -- Charlie Clark Managing Director Clark Consulting & Research German Office Kronenstr. 27a Düsseldorf D- 40217 Tel: +49-211-600-3657 Mobile: +49-178-782-6226 ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] [dev] CMFDefault: renaming type action urls
Hi!
Charlie Clark wrote:
Am 13.05.2013, 10:06 Uhr, schrieb yuppie :
Types: File, Image
Action: object/view
old: url_expr="string:${object_url}/file_view"
old: url_expr="string:${object_url}/image_view"
new: url_expr="string:${object_url}/view"
I think this is possibly the only one I would question: why the explicit
view as opposed to "/"? Is this difference between viewing the file or
image with metadata and when it is used as a resource elsewhere?
Yes. Default view and 'view' are identical for other content types, but
File and Image have a download view and a preview.
Otherwise it's a very sensible clean up of a wart of the old style
Meanwhile this is checked in. But if there are no objections I'd like to
make a small modification:
We have 'view' (not 'viewing') and 'edit' (not 'editing'), so I think we
should use 'share' instead of 'sharing' for local roles.
Cheers,
Yuppie
___
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf
See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] [dev] CMFDefault: renaming type action urls
Hi,
Am 13.05.2013, 10:06 Uhr, schrieb yuppie :
Types: File, Image
Action: object/view
old: url_expr="string:${object_url}/file_view"
old: url_expr="string:${object_url}/image_view"
new: url_expr="string:${object_url}/view"
I think this is possibly the only one I would question: why the explicit
view as opposed to "/"? Is this difference between viewing the file or
image with metadata and when it is used as a resource elsewhere? Otherwise
it's a very sensible clean up of a wart of the old style
Charlie
--
Charlie Clark
Managing Director
Clark Consulting & Research
German Office
Kronenstr. 27a
Düsseldorf
D- 40217
Tel: +49-211-600-3657
Mobile: +49-178-782-6226
___
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf
See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] [dev] CMFDefault: renaming type action urls
Hi Tres,
thanks for the feedback.
Tres Seaver wrote:
Types: Discussion Item, Document, Favorite, Link, News Item Action:
object/view old: url_expr="string:${object_url}/discussionitem_view"
old: url_expr="string:${object_url}/document_view" old:
url_expr="string:${object_url}/favorite_view" old:
url_expr="string:${object_url}/link_view" old:
url_expr="string:${object_url}/newsitem_view" new:
url_expr="string:${object_url}"
Types: File, Image Action: object/view old:
url_expr="string:${object_url}/file_view" old:
url_expr="string:${object_url}/image_view" new:
url_expr="string:${object_url}/view"
Types: File Action: object/download old:
url_expr="string:${object_url}" new: =
Types: Document, Favorite, File, Image, Link, News Item Action:
object/edit old: url_expr="string:${object_url}/document_edit_form"
old: url_expr="string:${object_url}/file_edit_form" old:
url_expr="string:${object_url}/image_edit_form" old:
url_expr="string:${object_url}/link_edit_form" old:
url_expr="string:${object_url}/newsitem_edit_form" new:
url_expr="string:${object_url}/edit" Action: object/metadata old:
url_expr="string:${object_url}/metadata_edit_form" new:
url_expr="string:${object_url}/properties"
Types: Folder, CMF BTree Folder Action: object/view old:
url_expr="string:${object_url}" new: = Action: object/folderContents
old: url_expr="string:${object_url}/folder_contents" new: = Action:
object/new (Action is deprecated) old:
url_expr="string:${object_url}/folder_factories" new: = Action:
object/localroles old:
url_expr="string:${object_url}/folder_localrole_form" new:
url_expr="string:${object_url}/sharing" Action: object/rename_items
(Action is obsolete with browser views) old:
url_expr="string:${object_url}/folder_rename_form" new: = Action:
object/edit old: url_expr="string:${object_url}/folder_edit_form" new:
url_expr="string:${object_url}/properties"
+1 overall. I've lost some context, so a couple of questions:
Guess I have to explain my list:
- - An empty value for 'new' means that the alias is being deleted?
You mean in my list? Using "new: =" I meant "same as old", not "empty".
If so,
do we make a distinction between a "download" view for files / images
(setting 'Content-disposition: attachment') vs. the "bare" URL?
- - Why have an alias from 'object/edit' to 'string:${object_url}/edit
Types: Document, Favorite, File, Image, Link, News Item
Action: object/edit
old: url_expr="string:${object_url}/document_edit_form"
old: url_expr="string:${object_url}/file_edit_form"
old: url_expr="string:${object_url}/image_edit_form"
old: url_expr="string:${object_url}/link_edit_form"
old: url_expr="string:${object_url}/newsitem_edit_form"
new: url_expr="string:${object_url}/edit"
'object/edit' specifies the Action: 'edit' Action in category 'object'
url_expr="string:${object_url}/edit" specifies the URL of the Action
'edit' isn't a skin method or a browser view, so we have to define
Method Aliases which are not shown in my list:
in a profile for browser views:
(for all types)
in a profile for old-style skins:
(for Document)
(for File)
(for Image)
(for Link, Favorite)
(for News Item)
Hope things are a bit clearer now.
Cheers,
Yuppie
___
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf
See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] [dev] CMFDefault: renaming type action urls
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 05/13/2013 04:06 AM, yuppie wrote:
> Hi!
>
>
> This just affects configuration. If you use your own profile, you can
> use different names. But nevertheless names shouldn't be changed too
> often and without a good reason. So I'd like to make sure there are
> no objections:
>
> We are in the process of replacing skin methods by browser views, but
> we still show the old skin method names in Action URLs. I'd like to
> get rid of type specific names and would prefer more generic names. A
> detailed list is at the bottom of this mail.
>
> Part of that change would be adjusting the Method Aliases and adding
> an upgrade step to make migration easier.
>
>
> Cheers,
>
> Yuppie
>
>
>
> Types: Discussion Item, Document, Favorite, Link, News Item Action:
> object/view old: url_expr="string:${object_url}/discussionitem_view"
> old: url_expr="string:${object_url}/document_view" old:
> url_expr="string:${object_url}/favorite_view" old:
> url_expr="string:${object_url}/link_view" old:
> url_expr="string:${object_url}/newsitem_view" new:
> url_expr="string:${object_url}"
>
> Types: File, Image Action: object/view old:
> url_expr="string:${object_url}/file_view" old:
> url_expr="string:${object_url}/image_view" new:
> url_expr="string:${object_url}/view"
>
> Types: File Action: object/download old:
> url_expr="string:${object_url}" new: =
>
> Types: Document, Favorite, File, Image, Link, News Item Action:
> object/edit old: url_expr="string:${object_url}/document_edit_form"
> old: url_expr="string:${object_url}/file_edit_form" old:
> url_expr="string:${object_url}/image_edit_form" old:
> url_expr="string:${object_url}/link_edit_form" old:
> url_expr="string:${object_url}/newsitem_edit_form" new:
> url_expr="string:${object_url}/edit" Action: object/metadata old:
> url_expr="string:${object_url}/metadata_edit_form" new:
> url_expr="string:${object_url}/properties"
>
> Types: Folder, CMF BTree Folder Action: object/view old:
> url_expr="string:${object_url}" new: = Action: object/folderContents
> old: url_expr="string:${object_url}/folder_contents" new: = Action:
> object/new (Action is deprecated) old:
> url_expr="string:${object_url}/folder_factories" new: = Action:
> object/localroles old:
> url_expr="string:${object_url}/folder_localrole_form" new:
> url_expr="string:${object_url}/sharing" Action: object/rename_items
> (Action is obsolete with browser views) old:
> url_expr="string:${object_url}/folder_rename_form" new: = Action:
> object/edit old: url_expr="string:${object_url}/folder_edit_form" new:
> url_expr="string:${object_url}/properties"
+1 overall. I've lost some context, so a couple of questions:
- - An empty value for 'new' means that the alias is being deleted? If so,
do we make a distinction between a "download" view for files / images
(setting 'Content-disposition: attachment') vs. the "bare" URL?
- - Why have an alias from 'object/edit' to 'string:${object_url}/edit
Tres.
- --
===
Tres Seaver +1 540-429-0999 tsea...@palladion.com
Palladion Software "Excellence by Design"http://palladion.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/
iEYEARECAAYFAlGQ7HAACgkQ+gerLs4ltQ7USwCg1L1MB+/kp9DJYAhmCNjk1+5E
3FwAoNHhY0hfMG30ntmHI8fAg4DmO1KN
=5hV3
-END PGP SIGNATURE-
___
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf
See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
[Zope-CMF] [dev] CMFDefault: renaming type action urls
Hi!
This just affects configuration. If you use your own profile, you can
use different names. But nevertheless names shouldn't be changed too
often and without a good reason. So I'd like to make sure there are no
objections:
We are in the process of replacing skin methods by browser views, but we
still show the old skin method names in Action URLs. I'd like to get rid
of type specific names and would prefer more generic names. A detailed
list is at the bottom of this mail.
Part of that change would be adjusting the Method Aliases and adding an
upgrade step to make migration easier.
Cheers,
Yuppie
Types: Discussion Item, Document, Favorite, Link, News Item
Action: object/view
old: url_expr="string:${object_url}/discussionitem_view"
old: url_expr="string:${object_url}/document_view"
old: url_expr="string:${object_url}/favorite_view"
old: url_expr="string:${object_url}/link_view"
old: url_expr="string:${object_url}/newsitem_view"
new: url_expr="string:${object_url}"
Types: File, Image
Action: object/view
old: url_expr="string:${object_url}/file_view"
old: url_expr="string:${object_url}/image_view"
new: url_expr="string:${object_url}/view"
Types: File
Action: object/download
old: url_expr="string:${object_url}"
new: =
Types: Document, Favorite, File, Image, Link, News Item
Action: object/edit
old: url_expr="string:${object_url}/document_edit_form"
old: url_expr="string:${object_url}/file_edit_form"
old: url_expr="string:${object_url}/image_edit_form"
old: url_expr="string:${object_url}/link_edit_form"
old: url_expr="string:${object_url}/newsitem_edit_form"
new: url_expr="string:${object_url}/edit"
Action: object/metadata
old: url_expr="string:${object_url}/metadata_edit_form"
new: url_expr="string:${object_url}/properties"
Types: Folder, CMF BTree Folder
Action: object/view
old: url_expr="string:${object_url}"
new: =
Action: object/folderContents
old: url_expr="string:${object_url}/folder_contents"
new: =
Action: object/new (Action is deprecated)
old: url_expr="string:${object_url}/folder_factories"
new: =
Action: object/localroles
old: url_expr="string:${object_url}/folder_localrole_form"
new: url_expr="string:${object_url}/sharing"
Action: object/rename_items (Action is obsolete with browser views)
old: url_expr="string:${object_url}/folder_rename_form"
new: =
Action: object/edit
old: url_expr="string:${object_url}/folder_edit_form"
new: url_expr="string:${object_url}/properties"
___
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf
See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
