Re: [Zope-CMF] Re: CachingPolicyManager improvements checked in to svn

2005-09-10 Thread Jens Vagelpohl
Here's the result of my refactoring/rewriting for the tests in question: http://svn.zope.org/CMF/branches/geoffd-cachingpolicymanager-branch/? rev=38439&view=rev Geoff, as the one with the most "domain knowledge" as far as the code changes go, could you check the tests (and especially the co

Re: [Zope-CMF] Re: CachingPolicyManager improvements checked in to svn

2005-09-09 Thread Sidnei da Silva
On Fri, Sep 09, 2005 at 04:33:48PM +0100, Jens Vagelpohl wrote: | >I'm still -1 on merging the branch as it is and Stefan confirmed | >that PortalTestCase should not be used directly: http:// | >mail.zope.org/pipermail/zope-cmf/2005-September/022932.html | | How about a compromise: I'll spend a

Re: [Zope-CMF] Re: CachingPolicyManager improvements checked in to svn

2005-09-09 Thread Jens Vagelpohl
On 9 Sep 2005, at 15:10, yuppie wrote: Geoff Davis wrote: On Fri, 09 Sep 2005 11:33:53 +0200, yuppie wrote: Are you aware of the fact that test_Template304Handling.py depends on PortalTestCase? Do you plan to change that before merging your branch? Yes, I am aware of that fact. No,

Re: Sane checkin mail delivery (was: Re: [Zope-CMF] Re: CachingPolicyManager improvements checked in to svn)

2005-09-08 Thread Paul Winkler
Dieter Maurer wrote: > Someone making occational changes may not be interested > to be informed about all the modifications going on. +1. -PW ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See htt

Re: [Zope-CMF] Re: CachingPolicyManager improvements checked in to svn

2005-09-08 Thread Sidnei da Silva
| The z3interfaces tests are based on the assumption that Five is | available if zope.interface is available. Five creates IActionInfo | dynamically on startup. | | That's obviously not true in your setup. Looking again at these tests it | would be more robust to include the interface imports i

Sane checkin mail delivery (was: Re: [Zope-CMF] Re: CachingPolicyManager improvements checked in to svn)

2005-09-08 Thread Dieter Maurer
Jens Vagelpohl wrote at 2005-9-8 11:41 +0100: > >On 8 Sep 2005, at 11:08, yuppie wrote: > ... >Geoff, can you double- >check that the email address you have in your zope.org membership is >correct and then subscribe to the cmf-checkins list? That should make >any further check-in messages appe

Re: [Zope-CMF] Re: CachingPolicyManager improvements checked in to svn

2005-09-08 Thread Jens Vagelpohl
On 8 Sep 2005, at 16:48, Geoff Davis wrote: bin/zopectl test --dir Products/CMFCore/tests I get a bunch of errors like the following: == ERROR: test_z3interfaces (CMFCore.tests.test_ActionInformation.ActionInfoTests) --

Re: [Zope-CMF] Re: CachingPolicyManager improvements checked in to svn

2005-09-08 Thread Jens Vagelpohl
On 8 Sep 2005, at 11:08, yuppie wrote: - Please make sure your checkins show up on the CMF-checkins list. Don't know if Tres can fix that for you or if you've got to register for that list. I was wondering why I did not get any mail... Geoff, can you double- check that the email address y