Re: [Zope-CMF] CMF Tests: 3 OK, 2 Failed
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 CMF Tests Summarizer wrote: > Summary of messages to the cmf-tests list. > Period Sun May 2 12:00:00 2010 UTC to Mon May 3 12:00:00 2010 UTC. > There were 5 messages: 5 from CMF Tests. > > > Test failures > - > > Subject: FAILED (errors=12) : CMF-2.2 Zope-2.12 Python-2.6.4 : Linux > From: CMF Tests > Date: Sun May 2 21:52:23 EDT 2010 > URL: http://mail.zope.org/pipermail/cmf-tests/2010-May/012947.html > > Subject: FAILED (errors=12) : CMF-trunk Zope-2.12 Python-2.6.4 : Linux > From: CMF Tests > Date: Sun May 2 21:54:23 EDT 2010 > URL: http://mail.zope.org/pipermail/cmf-tests/2010-May/012948.html My bad: I broke the 2.12 branch by backporting a fix badly from the trunk. They should run fine tonight. Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software "Excellence by Design"http://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkvfBt8ACgkQ+gerLs4ltQ7cAACfScs54Kl0rG3edbBX0eMmYZM2 zMUAoKYD35Ss30ZeXUTHdW3O68H2o55M =ksEJ -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] CMF Tests: 3 OK, 2 Failed
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 yuppie wrote: > After spending hours trying to understand the exception handling in > Zope, I think the unauth redirect code should be completely removed from > CookieCrumbler. An exception view seems to be a much more appropriate > solution. I'll write a prototype and report back. I think you are correct: registering appropriate exception views is the only sane way out of that jungle. The CookieCrumbler should get out of the "challenge" business altogether. Note that CC is largely useless already in any environment which uses a non-default user folder at the root: all the user folders written in the past decade already cope with this problem better than CC. Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software "Excellence by Design"http://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkvMg9MACgkQ+gerLs4ltQ55sQCglKKJpFwt64NlceJN2gT2JRQF ttMAnA+OE/GKqt/MKLWyZRrHwWJ5X3f6 =QdBp -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] CMF Tests: 3 OK, 2 Failed
Am 19.04.2010, 09:19 Uhr, schrieb yuppie : > I doubt you need to understand the failure and patch the tests for this. > With the id on class level they should work as before. You're right. Only the import/export tests needed updating as they used another id. > And please don't forget to remove the _create_forms code as well if > CookieCrumbler is no longer a Folder. Thanks for that. Changes now committed to trunk. >> I'll pick this up when I've made CookieCrumbler able to handle views. >> The >> plan on this is >> >> 1) Proper interface for CookieCrumbler >> >> 2) Use actions for login/logout > That also means you have to change the profile and add an upgrade step. For the profile I assume you mean cookieauth.xml ? login/logout actions are already defined. Having never previously written an upgrade step I'm a little unclear as to how to go about this. >> 3) Announce the deprecation (from CMF 2.4?) of the login/logout >> properties >> as these will be replaced by action lookups. Is there any point in >> maintaining the other properties as variables? > After spending hours trying to understand the exception handling in > Zope, I think the unauth redirect code should be completely removed from > CookieCrumbler. An exception view seems to be a much more appropriate > solution. I'll write a prototype and report back. From what I read of your posts on zope-dev this sounds reasonable. How would this affect CookieCrumbler? Get rid of the unauthorized and _unauthorized methods? There's probably not going to be much of CookieCrumbler left at the end of this. Although that might not be such a bad thing! Charlie -- Charlie Clark Managing Director Clark Consulting & Research German Office Helmholtzstr. 20 Düsseldorf D- 40215 Tel: +49-211-600-3657 Mobile: +49-178-782-6226 ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] CMF Tests: 3 OK, 2 Failed
Hi Charlie! Charlie Clark wrote: > Am 15.04.2010, 15:03 Uhr, schrieb yuppie: >> UniqueObject is derived from ImmutableId. I think you have to set this >> for the class: >> id = 'cookie_authentication' > > Okay, makes sense if the tests are patched accordingly. Need to check what > was causing your new doctest to fail. I doubt you need to understand the failure and patch the tests for this. With the id on class level they should work as before. And please don't forget to remove the _create_forms code as well if CookieCrumbler is no longer a Folder. > I'll pick this up when I've made CookieCrumbler able to handle views. The > plan on this is > > 1) Proper interface for CookieCrumbler > > 2) Use actions for login/logout That also means you have to change the profile and add an upgrade step. > 3) Announce the deprecation (from CMF 2.4?) of the login/logout properties > as these will be replaced by action lookups. Is there any point in > maintaining the other properties as variables? After spending hours trying to understand the exception handling in Zope, I think the unauth redirect code should be completely removed from CookieCrumbler. An exception view seems to be a much more appropriate solution. I'll write a prototype and report back. Cheers, Yuppie ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] CMF Tests: 3 OK, 2 Failed
Am 15.04.2010, 15:03 Uhr, schrieb yuppie : > AFAICS all 3 failures were caused by that change. Seems indeed to be the case. All better now - change committed. >> My mistake as I only tested >> against CMFCore although I don't quite understand how the import_export >> tests pass but this fails. Removing UniqueObject as base class fixes >> this >> so I'll commit that. Although, as I do think the CookieCrumbler should >> be >> unique in a site I'd be interested in fixing these tests so it can go >> back >> in. > UniqueObject is derived from ImmutableId. I think you have to set this > for the class: >id = 'cookie_authentication' Okay, makes sense if the tests are patched accordingly. Need to check what was causing your new doctest to fail. I'll pick this up when I've made CookieCrumbler able to handle views. The plan on this is 1) Proper interface for CookieCrumbler 2) Use actions for login/logout 3) Announce the deprecation (from CMF 2.4?) of the login/logout properties as these will be replaced by action lookups. Is there any point in maintaining the other properties as variables? Charlie -- Charlie Clark Managing Director Clark Consulting & Research German Office Helmholtzstr. 20 Düsseldorf D- 40215 Tel: +49-211-600-3657 Mobile: +49-178-782-6226 ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] CMF Tests: 3 OK, 2 Failed
Hi! Charlie Clark wrote: > Am 15.04.2010, 13:59 Uhr, schrieb CMF Tests Summarizer > : > >> Subject: FAILED (failures=3) : CMF-trunk Zope-2.12 Python-2.6.4 : Linux >> From: CMF Tests > > One of these is caused by my CookieCrumbler. AFAICS all 3 failures were caused by that change. > My mistake as I only tested > against CMFCore although I don't quite understand how the import_export > tests pass but this fails. Removing UniqueObject as base class fixes this > so I'll commit that. Although, as I do think the CookieCrumbler should be > unique in a site I'd be interested in fixing these tests so it can go back > in. UniqueObject is derived from ImmutableId. I think you have to set this for the class: id = 'cookie_authentication' Cheers, Yuppie ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] CMF Tests: 3 OK, 2 Failed
Am 15.04.2010, 13:59 Uhr, schrieb CMF Tests Summarizer : > Subject: FAILED (failures=3) : CMF-trunk Zope-2.12 Python-2.6.4 : Linux > From: CMF Tests One of these is caused by my CookieCrumbler. My mistake as I only tested against CMFCore although I don't quite understand how the import_export tests pass but this fails. Removing UniqueObject as base class fixes this so I'll commit that. Although, as I do think the CookieCrumbler should be unique in a site I'd be interested in fixing these tests so it can go back in. Charlie -- Charlie Clark Managing Director Clark Consulting & Research German Office Helmholtzstr. 20 Düsseldorf D- 40215 Tel: +49-211-600-3657 Mobile: +49-178-782-6226 ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
