Re: [Zope-dev] RFC: ETag support for zope.browserresource

2010-08-11 Thread Wichert Akkerman
On 2010-8-11 18:00, Marius Gedminas wrote: > On Tue, Aug 10, 2010 at 11:54:21PM +0300, Marius Gedminas wrote: >> Option #3: >> >>IResourceETag(request).computeETag(path, timestamp, data) >> >> Feels a bit ad-hoc. > > The more I think about this, the more I think it's best to configure > etag po

Re: [Zope-dev] RFC: ETag support for zope.browserresource

2010-08-11 Thread Marius Gedminas
On Tue, Aug 10, 2010 at 11:54:21PM +0300, Marius Gedminas wrote: > Option #3: > > IResourceETag(request).computeETag(path, timestamp, data) > > Feels a bit ad-hoc. The more I think about this, the more I think it's best to configure etag policy by providing an adapter on the request. I think

Re: [Zope-dev] RFC: ETag support for zope.browserresource

2010-08-10 Thread Marius Gedminas
On Tue, Aug 10, 2010 at 04:49:47PM -0300, Sidnei da Silva wrote: > On Tue, Aug 10, 2010 at 12:42 PM, Marius Gedminas wrote: > > How would you like that to be configured? > > > > Option #1: > > > >   ? > > > > Option #2: > > > >  getMultiAdapter((resource, request), IETag).computeETag() ? > > > >  

Re: [Zope-dev] RFC: ETag support for zope.browserresource

2010-08-10 Thread Sidnei da Silva
On Tue, Aug 10, 2010 at 12:42 PM, Marius Gedminas wrote: > How would you like that to be configured? > > Option #1: > >   ? > > Option #2: > >  getMultiAdapter((resource, request), IETag).computeETag() ? > >  This is maybe a bit problematic, because the actual File object that >  contains all the

Re: [Zope-dev] RFC: ETag support for zope.browserresource

2010-08-10 Thread Marius Gedminas
On Tue, Aug 10, 2010 at 08:49:53AM +0800, Martin Aspeli wrote: > On 10 August 2010 02:25, Marius Gedminas wrote: > > I've added ETag support for zope.browserresource in a branch: > > http://zope3.pov.lt/trac/changeset/115596 > > > > Does anybody have any comments/objections?  If not, I'd like to m

Re: [Zope-dev] RFC: ETag support for zope.browserresource

2010-08-10 Thread Marius Gedminas
On Mon, Aug 09, 2010 at 07:37:30PM -0300, Sidnei da Silva wrote: > On Mon, Aug 9, 2010 at 3:25 PM, Marius Gedminas wrote: > > I've added ETag support for zope.browserresource in a branch: > > http://zope3.pov.lt/trac/changeset/115596 > > > > Does anybody have any comments/objections?  If not, I'd

Re: [Zope-dev] RFC: ETag support for zope.browserresource

2010-08-09 Thread Christian Theune
On 08/10/2010 12:37 AM, Sidnei da Silva wrote: > On Mon, Aug 9, 2010 at 3:25 PM, Marius Gedminas wrote: >> I've added ETag support for zope.browserresource in a branch: >> http://zope3.pov.lt/trac/changeset/115596 >> >> Does anybody have any comments/objections? If not, I'd like to merge >> this

Re: [Zope-dev] RFC: ETag support for zope.browserresource

2010-08-09 Thread Martin Aspeli
On 10 August 2010 02:25, Marius Gedminas wrote: > I've added ETag support for zope.browserresource in a branch: > http://zope3.pov.lt/trac/changeset/115596 > > Does anybody have any comments/objections?  If not, I'd like to merge > this to trunk and release zope.browserresource 3.11.0. No strong

Re: [Zope-dev] RFC: ETag support for zope.browserresource

2010-08-09 Thread Sidnei da Silva
On Mon, Aug 9, 2010 at 3:25 PM, Marius Gedminas wrote: > I've added ETag support for zope.browserresource in a branch: > http://zope3.pov.lt/trac/changeset/115596 > > Does anybody have any comments/objections?  If not, I'd like to merge > this to trunk and release zope.browserresource 3.11.0. +1

Re: [Zope-dev] RFC: ETag support for zope.browserresource

2010-08-09 Thread Stephan Richter
On Monday, August 09, 2010, Marius Gedminas wrote: > Does anybody have any comments/objections? If not, I'd like to merge > this to trunk and release zope.browserresource 3.11.0. Looks good to me. Regards, Stephan -- Entrepreneur and Software Geek Google me. "Zope Stephan Richter" _

[Zope-dev] RFC: ETag support for zope.browserresource

2010-08-09 Thread Marius Gedminas
I've added ETag support for zope.browserresource in a branch: http://zope3.pov.lt/trac/changeset/115596 Does anybody have any comments/objections? If not, I'd like to merge this to trunk and release zope.browserresource 3.11.0. Marius Gedminas -- http://pov.lt/ -- Zope 3/BlueBream consulting an