Re: [Zope-dev] getUserById

2004-12-14 Thread Florent Guillaume
Chris McDonough wrote: On Tue, 2004-12-14 at 12:37 +0100, Florent Guillaume wrote: def getUserById(self, id, default=None): user = self.getUser(id) if user is not None: return user return default or even: def getUserById(self, id, default=None): return self.getUser(id) or defaul

Re: [Zope-dev] getUserById

2004-12-14 Thread Chris McDonough
On Tue, 2004-12-14 at 12:37 +0100, Florent Guillaume wrote: > def getUserById(self, id, default=None): > user = self.getUser(id) > if user is not None: > return user > return default > or even: > > def getUserById(self, id, default=None): > return self.getUser(id) or defau

Re: [Zope-dev] getUserById

2004-12-13 Thread Florent Guillaume
In article <[EMAIL PROTECTED]> you write: > Hm, I'd rather not raise exceptions. > > getUserById was introduced in Zope 2.2 and since then has never raised > anything. From what I can see it is used as a kind of alias for > getUser, expected to return None if the user does not exist. > > So, my

Re: [Zope-dev] getUserById

2004-12-13 Thread Florent Guillaume
Jens wrote: > On Dec 13, 2004, at 17:15, Florent Guillaume wrote: > > Can we have instead: > > > > def getUserById(self, id, default=_marker): > > """Return the user corresponding to the given id. > > > > Raises a KeyError if the user does not exist and no default > > is

Re: [Zope-dev] getUserById

2004-12-13 Thread Chris McDonough
On Mon, 2004-12-13 at 19:22 +0100, Stefan H. Holek wrote: > Hm, I'd rather not raise exceptions. > > getUserById was introduced in Zope 2.2 and since then has never raised > anything. From what I can see it is used as a kind of alias for > getUser, expected to return None if the user does not ex

Re: [Zope-dev] getUserById

2004-12-13 Thread Jens Vagelpohl
On Dec 13, 2004, at 17:15, Florent Guillaume wrote: Can we have instead: def getUserById(self, id, default=_marker): """Return the user corresponding to the given id. Raises a KeyError if the user does not exist and no default is provided. """ user = self

Re: [Zope-dev] getUserById

2004-12-13 Thread Lennart Regebro
Stefan H. Holek wrote: In User.py the method is defined as def getUserById(self, id, default=_marker): try: return self.getUser(id) except: if default is _marker: raise return default I am wondering whether anybody actually depends on the fact that getUser is suppos

Re: [Zope-dev] getUserById

2004-12-13 Thread Stefan H. Holek
Hm, I'd rather not raise exceptions. getUserById was introduced in Zope 2.2 and since then has never raised anything. From what I can see it is used as a kind of alias for getUser, expected to return None if the user does not exist. So, my intention is to make 'default' work, not to make it rais

Re: [Zope-dev] getUserById

2004-12-13 Thread Florent Guillaume
In article <[EMAIL PROTECTED]> you write: > In User.py the method is defined as > > def getUserById(self, id, default=_marker): > try: > return self.getUser(id) > except: > if default is _marker: raise > return default > > I am wondering whether anybody actual

[Zope-dev] getUserById

2004-12-12 Thread Stefan H. Holek
In User.py the method is defined as def getUserById(self, id, default=_marker): try: return self.getUser(id) except: if default is _marker: raise return default I am wondering whether anybody actually depends on the fact that getUser is supposed to raise an exceptio