Re: [Zope-dev] Avoid deprecation warnings in the testrunner
* 2009-12-24 07:12, Lennart Regebro wrote: > Yeah, that's fine by me. I see you did some ugly hacks to make it work > like making doctest.py into directory, but I don't have a problem with > that personally. I've tested the whole ZTK KGS using the current zope.testing's trunk and the only failing package was zope.minmax (already fixed in the trunk), because it imported zope.testing and used zope.testing.doctest, which fails now that doctest is a directory and not a file, as Lennnart pointed out. I think we should now make a new release for zope.testing and, obviously, zope.minmax. I don't have the rights on PyPI, can somebody help me (or add me, kobold)? Thanks, Fabio ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Avoid deprecation warnings in the testrunner
On Wed, Dec 23, 2009 at 23:04, Fabio Tranchitella wrote: > * 2009-12-23 22:48, Lennart Regebro wrote: >> OK, I'm tired. It's only a major undertaking if you remove it completely. >> zope.testings tests are mostly a question of running tests. Those should >> obviously still use zope.testing.doctest, and then it's a much smaller >> problem. > > This is exactly what I did in the trunk: zope.testing.doctest is still > there (so you can use it for declaring your doctests) it is not used > directly by the testrunner anymore because it uses the stdlib doctest. Yeah, that's fine by me. I see you did some ugly hacks to make it work like making doctest.py into directory, but I don't have a problem with that personally. -- Lennart Regebro: http://regebro.wordpress.com/ Python 3 Porting: http://python-incompatibility.googlecode.com/ +33 661 58 14 64 ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Avoid deprecation warnings in the testrunner
* 2009-12-23 22:48, Lennart Regebro wrote: > OK, I'm tired. It's only a major undertaking if you remove it completely. > zope.testings tests are mostly a question of running tests. Those should > obviously still use zope.testing.doctest, and then it's a much smaller > problem. This is exactly what I did in the trunk: zope.testing.doctest is still there (so you can use it for declaring your doctests) it is not used directly by the testrunner anymore because it uses the stdlib doctest. Best regards, Fabio ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Avoid deprecation warnings in the testrunner
On Wed, Dec 23, 2009 at 22:40, Lennart Regebro wrote: > Notice that replacing zope.testings use of it's own doctests module > with stdlibs one is a major undertaking. OK, I'm tired. It's only a major undertaking if you remove it completely. zope.testings tests are mostly a question of running tests. Those should obviously still use zope.testing.doctest, and then it's a much smaller problem. -- Lennart Regebro: http://regebro.wordpress.com/ Python 3 Porting: http://python-incompatibility.googlecode.com/ +33 661 58 14 64 ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Avoid deprecation warnings in the testrunner
Notice that replacing zope.testings use of it's own doctests module with stdlibs one is a major undertaking. I have done it as a part of the Python 3 branch, because I removed doctest.py from that branch. We could look into merging those changes without removing doctests.py, but I think we might even run into such simple problems as relative import paths clashing. -- Lennart Regebro: http://regebro.wordpress.com/ Python 3 Porting: http://python-incompatibility.googlecode.com/ +33 661 58 14 64 ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope.testing feature creep in release (WAS: zope.testing.doctestunit and BBB)
* 2009-12-23 16:13, Benji York wrote: > As for having a broken trunk: I believe that every project needs a head > maintainer that feels personally responsible for the state of a > particular project. They would be in charge of reviewing and approving > branches before they are merged to the project trunk. +1, we should make explicit who is responsible for which package. Zope2, Plone and other projects have the concept of "release manager", we don't have anybody responsible for the ZTK as a whole nor for a subset of the packages. Fabio ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Avoid deprecation warnings in the testrunner
I was (finally) able to patch zope.testing to use the standard Python doctest module while still supporting zope.testing.doctest if a package is importing and using it. The tests of zope.testing are passing on Python 2.4, 2.5 and 2.6 and the output from running the tests of a package which does not make use of zope.testing.doctest doesn't contain any deprecation warning, yay! I committed my changes to the trunk. I'd appreciate if somebody would check the diff and, if nobody object, upload a new release of zope.testing (I don't have the rights on PyPI, my nickname is kobold). Best regards. Fabio * 2009-12-23 14:38, Fabio Tranchitella wrote: > ... ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope.testing feature creep in release (WAS: zope.testing.doctestunit and BBB)
On Wed, Dec 23, 2009 at 4:58 AM, Christian Theune wrote: > Nevertheless, I think the (agile, many, flexible, easy) releases and not > branching the trunk at all start hurting us here as we're getting lost > in our own policy. Any ideas for limiting feature creep? Two comments: Whenever I wish I had created a major release branch (like /branches/1.5) at that point I go back and create one by copying the 1.5.0 tag. That way you have the best of both worlds, you don't have to remember to create major release branches (that you may never use) and you can have them if you end up doing significant maintenance on that version. As for having a broken trunk: I believe that every project needs a head maintainer that feels personally responsible for the state of a particular project. They would be in charge of reviewing and approving branches before they are merged to the project trunk. We've inherited a communal process from the pre-explosion days that worked well there, but there are just too many projects for the community to keep track of and to care for. -- Benji York ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Avoid deprecation warnings in the testrunner
Hello,
* 2009-12-23 14:33, Marius Gedminas wrote:
> > @@ -328,6 +327,9 @@
> > def format_traceback(self, exc_info):
> > """Format the traceback."""
> > v = exc_info[1]
> > +warnings.simplefilter('ignore')
> > +from zope.testing import doctest
> > +warnings.filters.pop()
>
> I'm not thrilled.
Me neither, but if I don't do that, I will have a lot of test failures
because the deprecation warning will be printed in the middle of the tests.
> Can we 'import doctest' from the stdlib, and hope that these isinstance
> checks work fine?
No, it doesn't because the first if is about an exception which is
zope.testing.doctest-specific.
> Specifically, can we make it so that zope.testing.doctest's exceptions
> _inherit_ from stdlib's doctest exceptions?
I couldn't find the way to do it.
> > ===
> > --- src/zope/testing/testrunner/doctest.py (revisione 106999)
> > +++ src/zope/testing/testrunner/doctest.py (copia locale)
> > @@ -17,10 +17,11 @@
> > """
> >
> > import sys
> > -from zope.testing import doctest
> > import zope.testing.testrunner.feature
> >
> > +from zope.testing import doctest
> >
> > +
>
> Doesn't seem like much of a change ;)
> Suggest importing stdlib here as well.
Same reason, we cannot use the standard doctest because it doesn't have
the feature needed there.
> > -self.features.append(zope.testing.testrunner.doctest.DocTest(self))
> > +if options.ndiff or options.udiff or options.cdiff or \
> > + options.report_only_first_failure is not None:
> > +from zope.testing.testrunner.doctest import DocTest
> > +self.features.append(DocTest(self))
>
> A *strong* -1 for this bit.
This is the only way I could avoid deprecation warnings for a test that
doesn't need zope.testing-specific doctest features. Better ideas?
Fabio
___
Zope-Dev maillist - Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Avoid deprecation warnings in the testrunner
On Wed, Dec 23, 2009 at 01:36:33PM +0100, Fabio Tranchitella wrote:
> I think we should provide a zope.testing package which does not emit
> deprecation warnings while running the testrunner on other packages,
> otherwise there is no way to really understand why the package you are
> working on is using a deprecated API.
+1
> I propose the patch attached to this message to zope.testing.
>
> It tries to avoid importing zope.testing.doctest unless it is really
> needed. In this way, developers can see the DeprecationWarning with the
> path of *their* code, and fix it, instead of receiving the
> DeprecationWarning because the testrunner imports zope.testing.doctest
> itself.
>
> Before applying the patch, running the tests on another package produced
> this output:
>
> ---
> .../zope/testing/testrunner/debug.py:23: DeprecationWarning:
> zope.testing.doctest is deprecated in favour of the Python standard library
> doctest module
> from zope.testing import doctest
> Running zope.testing.testrunner.layer.UnitTests tests:
> ...
> ---
>
> After applying my patch, I get this:
>
> ---
> .../zope/interface/tests/test_adapter.py:405: DeprecationWarning:
> zope.testing.doctest is deprecated in favour of the Python standard library
> doctest module
> from zope.testing import doctest
> Running zope.testing.testrunner.layer.UnitTests tests:
> ...
> ---
>
> Comments?
Let's look at it:
> Thanks,
> Fabio
> Index: src/zope/testing/testrunner/formatter.py
> ===
> --- src/zope/testing/testrunner/formatter.py (revisione 106999)
> +++ src/zope/testing/testrunner/formatter.py (copia locale)
> @@ -19,10 +19,9 @@
> import sys
> import re
> import traceback
> +import warnings
>
> -from zope.testing import doctest
>
> -
> doctest_template = """
> File "%s", line %s, in %s
>
> @@ -328,6 +327,9 @@
> def format_traceback(self, exc_info):
> """Format the traceback."""
> v = exc_info[1]
> +warnings.simplefilter('ignore')
> +from zope.testing import doctest
> +warnings.filters.pop()
I'm not thrilled.
Can we 'import doctest' from the stdlib, and hope that these isinstance
checks work fine?
Specifically, can we make it so that zope.testing.doctest's exceptions
_inherit_ from stdlib's doctest exceptions?
Otherwise people who convert to stdlib's doctest to avoid deprecation
warnings will lose all the nice doctest formatting and post-mortem
debugging bits they're accustomed to.
> if isinstance(v, doctest.DocTestFailureException):
> tb = v.args[0]
> elif isinstance(v, doctest.DocTestFailure):
> @@ -560,6 +562,9 @@
> print
> print self.colorize('error', msg)
> v = exc_info[1]
> +warnings.simplefilter('ignore');
> +from zope.testing import doctest
> +warnings.filters.pop()
> if isinstance(v, doctest.DocTestFailureException):
> self.print_doctest_failure(v.args[0])
> elif isinstance(v, doctest.DocTestFailure):
> Index: src/zope/testing/testrunner/doctest.py
> ===
> --- src/zope/testing/testrunner/doctest.py(revisione 106999)
> +++ src/zope/testing/testrunner/doctest.py(copia locale)
> @@ -17,10 +17,11 @@
> """
>
> import sys
> -from zope.testing import doctest
> import zope.testing.testrunner.feature
>
> +from zope.testing import doctest
>
> +
Doesn't seem like much of a change ;)
Suggest importing stdlib here as well.
> class DocTest(zope.testing.testrunner.feature.Feature):
>
> active = True
> Index: src/zope/testing/testrunner/runner.py
> ===
> --- src/zope/testing/testrunner/runner.py (revisione 106999)
> +++ src/zope/testing/testrunner/runner.py (copia locale)
> @@ -34,7 +34,6 @@
> from zope.testing.testrunner.refcount import TrackRefs
> from zope.testing.testrunner.options import get_options
> import zope.testing.testrunner.coverage
> -import zope.testing.testrunner.doctest
> import zope.testing.testrunner.logsupport
> import zope.testing.testrunner.selftest
> import zope.testing.testrunner.profiling
> @@ -177,7 +176,10 @@
> self.features.append(zope.testing.testrunner.selftest.SelfTest(self))
>
> self.features.append(zope.testing.testrunner.logsupport.Logging(self))
> self.features.append(zope.testing.testrunner.coverage.Coverage(self))
> -self.features.append(zope.testing.testrunner.doctest.DocTest(self))
> +if options.ndiff or options.udiff or options.cdiff or \
> + options.report_only_first_fa
[Zope-dev] Avoid deprecation warnings in the testrunner
Hello,
I think we should provide a zope.testing package which does not emit
deprecation warnings while running the testrunner on other packages,
otherwise there is no way to really understand why the package you are
working on is using a deprecated API.
I propose the patch attached to this message to zope.testing.
It tries to avoid importing zope.testing.doctest unless it is really
needed. In this way, developers can see the DeprecationWarning with the
path of *their* code, and fix it, instead of receiving the
DeprecationWarning because the testrunner imports zope.testing.doctest
itself.
Before applying the patch, running the tests on another package produced
this output:
---
.../zope/testing/testrunner/debug.py:23: DeprecationWarning:
zope.testing.doctest is deprecated in favour of the Python standard library
doctest module
from zope.testing import doctest
Running zope.testing.testrunner.layer.UnitTests tests:
...
---
After applying my patch, I get this:
---
.../zope/interface/tests/test_adapter.py:405: DeprecationWarning:
zope.testing.doctest is deprecated in favour of the Python standard library
doctest module
from zope.testing import doctest
Running zope.testing.testrunner.layer.UnitTests tests:
...
---
Comments?
Thanks,
Fabio
Index: src/zope/testing/testrunner/formatter.py
===
--- src/zope/testing/testrunner/formatter.py (revisione 106999)
+++ src/zope/testing/testrunner/formatter.py (copia locale)
@@ -19,10 +19,9 @@
import sys
import re
import traceback
+import warnings
-from zope.testing import doctest
-
doctest_template = """
File "%s", line %s, in %s
@@ -328,6 +327,9 @@
def format_traceback(self, exc_info):
"""Format the traceback."""
v = exc_info[1]
+warnings.simplefilter('ignore')
+from zope.testing import doctest
+warnings.filters.pop()
if isinstance(v, doctest.DocTestFailureException):
tb = v.args[0]
elif isinstance(v, doctest.DocTestFailure):
@@ -560,6 +562,9 @@
print
print self.colorize('error', msg)
v = exc_info[1]
+warnings.simplefilter('ignore');
+from zope.testing import doctest
+warnings.filters.pop()
if isinstance(v, doctest.DocTestFailureException):
self.print_doctest_failure(v.args[0])
elif isinstance(v, doctest.DocTestFailure):
Index: src/zope/testing/testrunner/doctest.py
===
--- src/zope/testing/testrunner/doctest.py (revisione 106999)
+++ src/zope/testing/testrunner/doctest.py (copia locale)
@@ -17,10 +17,11 @@
"""
import sys
-from zope.testing import doctest
import zope.testing.testrunner.feature
+from zope.testing import doctest
+
class DocTest(zope.testing.testrunner.feature.Feature):
active = True
Index: src/zope/testing/testrunner/runner.py
===
--- src/zope/testing/testrunner/runner.py (revisione 106999)
+++ src/zope/testing/testrunner/runner.py (copia locale)
@@ -34,7 +34,6 @@
from zope.testing.testrunner.refcount import TrackRefs
from zope.testing.testrunner.options import get_options
import zope.testing.testrunner.coverage
-import zope.testing.testrunner.doctest
import zope.testing.testrunner.logsupport
import zope.testing.testrunner.selftest
import zope.testing.testrunner.profiling
@@ -177,7 +176,10 @@
self.features.append(zope.testing.testrunner.selftest.SelfTest(self))
self.features.append(zope.testing.testrunner.logsupport.Logging(self))
self.features.append(zope.testing.testrunner.coverage.Coverage(self))
-self.features.append(zope.testing.testrunner.doctest.DocTest(self))
+if options.ndiff or options.udiff or options.cdiff or \
+ options.report_only_first_failure is not None:
+from zope.testing.testrunner.doctest import DocTest
+self.features.append(DocTest(self))
self.features.append(zope.testing.testrunner.profiling.Profiling(self))
if is_jython:
# Jython GC support is not yet implemented
Index: src/zope/testing/testrunner/debug.py
===
--- src/zope/testing/testrunner/debug.py (revisione 106999)
+++ src/zope/testing/testrunner/debug.py (copia locale)
@@ -20,12 +20,12 @@
import sys
import pdb
-from zope.testing import doctest
import zope.testing.testrunner.interfaces
def post_mortem(exc_info):
err = exc_info[1]
+from zope.testing import doctest
if isinstance(err, (doctest.UnexpectedException, doctest.DocTest
[Zope-dev] Zope Tests: 6 OK
Summary of messages to the zope-tests list. Period Tue Dec 22 12:00:00 2009 UTC to Wed Dec 23 12:00:00 2009 UTC. There were 6 messages: 6 from Zope Tests. Tests passed OK --- Subject: OK : Zope-2.10 Python-2.4.6 : Linux From: Zope Tests Date: Tue Dec 22 20:37:09 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-December/013245.html Subject: OK : Zope-2.11 Python-2.4.6 : Linux From: Zope Tests Date: Tue Dec 22 20:39:09 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-December/013246.html Subject: OK : Zope-2.12 Python-2.6.4 : Linux From: Zope Tests Date: Tue Dec 22 20:41:09 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-December/013247.html Subject: OK : Zope-2.12-alltests Python-2.6.4 : Linux From: Zope Tests Date: Tue Dec 22 20:43:09 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-December/013248.html Subject: OK : Zope-trunk Python-2.6.4 : Linux From: Zope Tests Date: Tue Dec 22 20:45:09 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-December/013249.html Subject: OK : Zope-trunk-alltests Python-2.6.4 : Linux From: Zope Tests Date: Tue Dec 22 20:47:09 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-December/013250.html ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] New release of zope.interface
On 12/23/09 8:03 AM, Marius Gedminas wrote: > On Wed, Dec 23, 2009 at 06:34:17AM +, Matthew Wilkes wrote: >> >> On 2009-12-23, at 0624, Marius Gedminas wrote: >> >>> Releasing 3.8.5 now. >> >> …and it's broken. The testrunner directory isn't included in the >> tarball so egg_info fails. > > Gah, setuptools claims another victim! I must be using a version that > doesn't support svn 1.6 working dirs. :( > > Can we please have a check for that in zest.releaser? A check for that? Seems sensible. I'm not getting around to do that (last two days in my current job; laptopless in the weekend) in the next few days, though. Reinout -- Reinout van Rees - rein...@vanrees.org - http://reinout.vanrees.org Software developer at http://www.thehealthagency.com "Military engineers build missiles. Civil engineers build targets" ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Testrunner option for running tests in random order?!?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 12/18/2009 02:49 PM, Jonathan Ballet wrote: | Hi, | | On Fri, Dec 18, 2009 at 1:51 PM, Christian Theune wrote: |> |> Reviewed and merged. |> |> I made some minor textual changes, otherwise that code was fine. | | Thank you Christian! | BTW, the Pypi page for zope.testing is a bit broken currently (the | HTML has not been generated), can you fix this too? Gnah. I stared at this for a while and didn't find any fault. Turns out it probably was a glitch when registering that version with PyPI. I re-registered the 3.8.6 package and the page shows fine now. Christian - -- Christian Theune · c...@gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1 Zope and Plone consulting and development -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAksx7CYACgkQdUt9X/gknwJ4QACgh6dH8M4a1/3uNLAc16PGhi5n gBQAoJnZCmAFLWttyhmQt1LfkTp7z5ct =G0// -END PGP SIGNATURE- smime.p7s Description: S/MIME Cryptographic Signature ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] zope.testing feature creep in release (WAS: zope.testing.doctestunit and BBB)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/23/2009 10:55 AM, Lennart Regebro wrote: | On Wed, Dec 23, 2009 at 10:25, Christian Theune wrote: |> Is this about getting rid of our own doctest and relying on Python's |> standard doctest module? | | The deprecations are, yes. The problem (which has now been fixed) is | that some BBB imports was not marked as being BBB imports and | therefore was removed in a cleanup. Sounds like regular maintenance for me then which I won't oppose regarding a release. On a related note: we're getting sloppy with the zope.testing releases AFAICT as the current minor version included several feature changes. I sneaked in the last one myself because I wanted to get rid of that review without having to think hard about the already broken branch. Nevertheless, I think the (agile, many, flexible, easy) releases and not branching the trunk at all start hurting us here as we're getting lost in our own policy. Any ideas for limiting feature creep? Christian - -- Christian Theune · c...@gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1 Zope and Plone consulting and development -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAksx6d4ACgkQdUt9X/gknwLzYQCgwyC7AYcKtEKjt9byVDhRkrtH FQIAoK7ku/+gWcPEnO5GBPWYzPNuHK6N =HFJc -END PGP SIGNATURE- smime.p7s Description: S/MIME Cryptographic Signature ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope.testing.doctestunit and BBB
On Wed, Dec 23, 2009 at 10:25, Christian Theune wrote: > Is this about getting rid of our own doctest and relying on Python's > standard doctest module? The deprecations are, yes. The problem (which has now been fixed) is that some BBB imports was not marked as being BBB imports and therefore was removed in a cleanup. -- Lennart Regebro: http://regebro.wordpress.com/ Python 3 Porting: http://python-incompatibility.googlecode.com/ +33 661 58 14 64 ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope.testing.doctestunit and BBB
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 12/21/2009 10:27 PM, Lennart Regebro wrote: | On Mon, Dec 21, 2009 at 22:23, Marius Gedminas wrote: |> On Mon, Dec 21, 2009 at 07:41:24PM +0100, Lennart Regebro wrote: |>> On Mon, Dec 21, 2009 at 13:20, Marius Gedminas wrote: |>>> Can you please make it a PendingDeprecationWarning first? |>> |>> Yeah, I guess, but why? |> |> Because I hate it when my code emits DeprecationWarnings, and I wasn't |> sure I could throw a switch and migrate to stdlib's doctest.py today |> without extensive tests/preparation. |> |> Key word being "wasn't". |> |> I migrated my codebase to use stdlib's doctest.py today, and nothing |> broke, to my surprise. Even coverage support continues to work fine (at |> some point just having 'import doctest' could make bin/test --coverage |> forget about half the code it's seen). |> |> So, I'm fine with a DeprecationWarning. | | Good to hear. I thought they should work, the differences are mostly | in output formatting and such. | | I added the imports back, and also some deprecation warnings, although | I'm not sure how to best add them, so I just stuck them in the | modules, so the first import will raise a warning. A new release would | be great, I guess. Christian, what do you say? I'm sorry, I was out of the loop for a while. Is this about getting rid of our own doctest and relying on Python's standard doctest module? Christian - -- Christian Theune · c...@gocept.com gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1 Zope and Plone consulting and development -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAksx4hYACgkQdUt9X/gknwLqTwCgnCVClMa+I6DjeBa5Baqf/Foo JFEAn2rsUrEp+etmeOZHnIyCGPa2I91i =Jw/h -END PGP SIGNATURE- smime.p7s Description: S/MIME Cryptographic Signature ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] New release of zope.interface
Hello Marius, Wednesday, December 23, 2009, 8:03:31 AM, you wrote: MG> Gah, setuptools claims another victim! I must be using a version that MG> doesn't support svn 1.6 working dirs. :( yah. But it seems to get it right after a bin/buildout. -- Best regards, Adam GROSZERmailto:agros...@gmail.com -- Quote of the day: This screen intentionally left blank. ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
