Re: [Zope-dev] RFC: ETag support for zope.browserresource
On 08/10/2010 12:37 AM, Sidnei da Silva wrote: On Mon, Aug 9, 2010 at 3:25 PM, Marius Gedminasmar...@gedmin.as wrote: I've added ETag support for zope.browserresource in a branch: http://zope3.pov.lt/trac/changeset/115596 Does anybody have any comments/objections? If not, I'd like to merge this to trunk and release zope.browserresource 3.11.0. +1 as long as there's a way to disable or configure how it's computed. There's some information about issues with ETags here: http://developer.yahoo.com/performance/rules.html#etags I see that your implementation uses last-modified + size, which should generally be fine. However if you're load-balancing across two different servers and the timestamps don't match then the ETag is useless. On a completely different note, I see that the File object reads the whole file into memory. Hum. Maybe RAM is cheaper than Disk these days and it doesn't matter, but reading whole files into memory generally raises a red flag for me. IOPS aren't cheap nowadays. The IOPS/MB have had the issue that the MB kept increasing a lot in disks but the IOPS didn't catch up that much, so it may not even be a RAM issue but throughput/caching/IOPS. -- Christian Theune · c...@gocept.com gocept gmbh co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1 Zope and Plone consulting and development ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope.i18nmessageid 3.5.3 released (windows binaries needed)
On 08/10/2010 07:19 AM, Chris McDonough wrote: I made a new release of zope.i18nmessageid (3.5.3) persuant to a conversation that took place on this list a few weeks ago related to switching back to overriding build_ext to allow the package to work on Jython and other CPython platforms. Would someone be kind enough to build and upload new Windows binaries? Hmm. There should be dragons here that take care of that automatically if I understood the wineggbuilder correctly. -- Christian Theune · c...@gocept.com gocept gmbh co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1 Zope and Plone consulting and development ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope.i18nmessageid 3.5.3 released (windows binaries needed)
Hello Chris, No worries about windows eggs, winbot should do it: http://winbot.zope.org/builders/wineggbuilder Tuesday, August 10, 2010, 7:19:34 AM, you wrote: CM I made a new release of zope.i18nmessageid (3.5.3) persuant to a CM conversation that took place on this list a few weeks ago related to CM switching back to overriding build_ext to allow the package to work on CM Jython and other CPython platforms. CM Would someone be kind enough to build and upload new Windows binaries? CM Here's the related changelog entries: CM 3.5.3 (2010-08-10) CM -- CM CM - Made compilation of C extension optional again; 3.5.1 broke this CM inasmuch as this package become unusable on non-CPython platforms. CM Making the compilation of the C extension optional again implied CM removing ``setup.py`` code added in 3.5.1 which made the C extension CM a setuptools Feature and readding code from 3.5.0 which overrides CM the distutils ``build_ext`` command. CM CM - Move pickle equality tests into a unittest.TestCase test to make it CM easier to condition the tests on whether the C extension has been CM compiled. This also makes the tests pass on Jython. CM ___ CM Zope-Dev maillist - Zope-Dev@zope.org CM https://mail.zope.org/mailman/listinfo/zope-dev CM ** No cross posts or HTML encoding! ** CM (Related lists - CM https://mail.zope.org/mailman/listinfo/zope-announce CM https://mail.zope.org/mailman/listinfo/zope ) -- Best regards, Adam GROSZERmailto:agros...@gmail.com -- Quote of the day: He who thinks most of heaven will do most for earth. - Anonymous ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Zope Tests: 36 OK, 8 Failed, 1 Unknown
Summary of messages to the zope-tests list. Period Mon Aug 9 12:00:00 2010 UTC to Tue Aug 10 12:00:00 2010 UTC. There were 45 messages: 6 from Zope Tests, 1 from buildbot at enfoldsystems.com, 4 from buildbot at pov.lt, 13 from buildbot at winbot.zope.org, 8 from ccomb at free.fr, 13 from jdriessen at thehealthagency.com. Test failures - Subject: FAILED (failures=1) : Zope-trunk Python-2.6.5 : Linux From: Zope Tests Date: Mon Aug 9 21:39:25 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018158.html Subject: FAILED : winbot / ztk_dev py_244_win32 From: buildbot at winbot.zope.org Date: Mon Aug 9 22:08:34 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018163.html Subject: FAILED : winbot / ztk_dev py_254_win32 From: buildbot at winbot.zope.org Date: Mon Aug 9 22:15:55 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018165.html Subject: FAILED : winbot / ztk_dev py_265_win32 From: buildbot at winbot.zope.org Date: Mon Aug 9 22:22:45 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018166.html Subject: FAILED : winbot / ztk_dev py_265_win64 From: buildbot at winbot.zope.org Date: Mon Aug 9 22:29:28 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018167.html Subject: FAILED : winbot / ztk_10 py_244_win32 From: buildbot at winbot.zope.org Date: Mon Aug 9 22:37:36 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018169.html Subject: FAILED : winbot / ZODB_dev py_270_win32 From: buildbot at winbot.zope.org Date: Tue Aug 10 03:12:51 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018181.html Subject: FAILED : winbot / ZODB_dev py_270_win64 From: buildbot at winbot.zope.org Date: Tue Aug 10 04:08:24 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018186.html Unknown --- Subject: [zodb-tests] buildbot failure in Enfold Systems on zodb-trunk-python-2.6-maestro From: buildbot at enfoldsystems.com Date: Tue Aug 10 04:00:54 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018185.html Tests passed OK --- Subject: OK : Zope 3.4 Known Good Set / py2.4-64bit-linux From: buildbot at pov.lt Date: Mon Aug 9 21:09:24 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018152.html Subject: OK : Zope 3.4 Known Good Set / py2.4-32bit-linux From: buildbot at pov.lt Date: Mon Aug 9 21:30:07 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018153.html Subject: OK : Zope-2.10 Python-2.4.6 : Linux From: Zope Tests Date: Mon Aug 9 21:31:25 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018154.html Subject: OK : Zope-2.11 Python-2.4.6 : Linux From: Zope Tests Date: Mon Aug 9 21:33:25 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018155.html Subject: OK : Zope-2.12 Python-2.6.5 : Linux From: Zope Tests Date: Mon Aug 9 21:35:25 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018156.html Subject: OK : Zope-2.12-alltests Python-2.6.5 : Linux From: Zope Tests Date: Mon Aug 9 21:37:25 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018157.html Subject: OK : Zope-trunk-alltests Python-2.6.5 : Linux From: Zope Tests Date: Mon Aug 9 21:41:26 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018159.html Subject: OK : Bluebream / Python2.4.6 32bit linux From: ccomb at free.fr Date: Mon Aug 9 22:06:18 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018160.html Subject: OK : Bluebream / Python2.5.2 32bit linux From: ccomb at free.fr Date: Mon Aug 9 22:06:29 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018161.html Subject: OK : Bluebream / Python2.6.4 32bit linux From: ccomb at free.fr Date: Mon Aug 9 22:06:31 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018162.html Subject: OK : Zope 3.4 Known Good Set / py2.5-64bit-linux From: buildbot at pov.lt Date: Mon Aug 9 22:09:15 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018164.html Subject: OK : Zope 3.4 Known Good Set / py2.5-32bit-linux From: buildbot at pov.lt Date: Mon Aug 9 22:30:55 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018168.html Subject: OK : winbot / ztk_10 py_254_win32 From: buildbot at winbot.zope.org Date: Mon Aug 9 22:45:17 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018170.html Subject: OK : winbot / ztk_10 py_265_win32 From: buildbot at winbot.zope.org Date: Mon Aug 9 22:52:30 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018171.html Subject: OK : winbot / ztk_10 py_265_win64 From: buildbot at winbot.zope.org Date: Mon Aug 9 22:59:45 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-August/018172.html Subject: OK : winbot / ZODB_dev py_254_win32 From: buildbot at winbot.zope.org Date: Tue Aug 10 00:27:58 EDT 2010 URL:
[Zope-dev] Developer meeting 2010-08-10 at 15:00 UTC
Hi everyone, today's another meeting coming up. Charlie asked for talking about the summit and the upcoming Zope/Python/Plone conference in Germany. I'd like to get back to the documentation and also the automated builders (there's still too much noise going on IMHO). Agenda (in a few minutes): http://docs.zope.org/zopetoolkit/zope-dev/zope-dev-20100810.html Christian -- Christian Theune · c...@gocept.com gocept gmbh co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1 Zope and Plone consulting and development ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] RFC: ETag support for zope.browserresource
On Mon, Aug 09, 2010 at 07:37:30PM -0300, Sidnei da Silva wrote: On Mon, Aug 9, 2010 at 3:25 PM, Marius Gedminas mar...@gedmin.as wrote: I've added ETag support for zope.browserresource in a branch: http://zope3.pov.lt/trac/changeset/115596 Does anybody have any comments/objections? If not, I'd like to merge this to trunk and release zope.browserresource 3.11.0. +1 as long as there's a way to disable or configure how it's computed. How would you like that to be configured? Option #1: browser:resource/resourceDirectory etags=off / ? Option #2: getMultiAdapter((resource, request), IETag).computeETag() ? This is maybe a bit problematic, because the actual File object that contains all the data--such as filename--doesn't implement any interfaces. And neither does FileResource. There's some information about issues with ETags here: http://developer.yahoo.com/performance/rules.html#etags I see that your implementation uses last-modified + size, which should generally be fine. However if you're load-balancing across two different servers and the timestamps don't match then the ETag is useless. Would you prefer a sha1 checksum? On a completely different note, I see that the File object reads the whole file into memory. And it does that twice for every request that results in a 200 response: once to auto-detect the content-type, the second time to return the actual data. Hum. Maybe RAM is cheaper than Disk these days and it doesn't matter, but reading whole files into memory generally raises a red flag for me. hoping-no-one-is-serving-iso-files-through-zope.browserresource-ly yours, Marius Gedminas -- http://pov.lt/ -- Zope 3/BlueBream consulting and development signature.asc Description: Digital signature ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] RFC: ETag support for zope.browserresource
On Tue, Aug 10, 2010 at 08:49:53AM +0800, Martin Aspeli wrote: On 10 August 2010 02:25, Marius Gedminas mar...@gedmin.as wrote: I've added ETag support for zope.browserresource in a branch: http://zope3.pov.lt/trac/changeset/115596 Does anybody have any comments/objections? If not, I'd like to merge this to trunk and release zope.browserresource 3.11.0. No strong objections, really, but bear in mind that people will likely want to customise this. Do you have any ideas about the API for customizing this? With plone.caching / plone.app.caching we have a framework that, among other things, deals with browser resources and sets etag, last-modified and other headers according to rules configured by the developer and/or administrator. Is it built on top of zope.browserresource, or is it entirely independent? I've grepped the sources of both plone.caching and plone.app.caching. They don't import zope.browserresource, so I guess the answer is wndependent, unless I'm missing something. Your next sentence leads me to think I *am* missing something: I think that would just stomp on etags set by zope.browserresource, but then zope.browserresource's GET handler would reject _your_ etag in its If-None-Matches header check, so there may be a problem here? but worth bearing in mind that for bigger applications like Plone, we need a centralised, overarching and configurable strategy for cache headers. Marius Gedminas -- http://pov.lt/ -- Zope 3/BlueBream consulting and development signature.asc Description: Digital signature ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] RFC: ETag support for zope.browserresource
On Tue, Aug 10, 2010 at 12:42 PM, Marius Gedminas mar...@gedmin.as wrote: How would you like that to be configured? Option #1: browser:resource/resourceDirectory etags=off / ? Option #2: getMultiAdapter((resource, request), IETag).computeETag() ? This is maybe a bit problematic, because the actual File object that contains all the data--such as filename--doesn't implement any interfaces. And neither does FileResource. So maybe Option #1? I see that your implementation uses last-modified + size, which should generally be fine. However if you're load-balancing across two different servers and the timestamps don't match then the ETag is useless. Would you prefer a sha1 checksum? As a default? I'd say last-modified + size is OK. On a completely different note, I see that the File object reads the whole file into memory. And it does that twice for every request that results in a 200 response: once to auto-detect the content-type, the second time to return the actual data. Ouch. That sounds pretty bad. I thought it kept the data in-memory (didn't look close enough at the source). -- Sidnei ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] RFC: ETag support for zope.browserresource
On Tue, Aug 10, 2010 at 04:49:47PM -0300, Sidnei da Silva wrote: On Tue, Aug 10, 2010 at 12:42 PM, Marius Gedminas mar...@gedmin.as wrote: How would you like that to be configured? Option #1: browser:resource/resourceDirectory etags=off / ? Option #2: getMultiAdapter((resource, request), IETag).computeETag() ? This is maybe a bit problematic, because the actual File object that contains all the data--such as filename--doesn't implement any interfaces. And neither does FileResource. So maybe Option #1? But then it's not easily overridable, globally, for a particular application, since each package may have its own browser:resource declarations. Option #3: IResourceETag(request).computeETag(path, timestamp, data) Feels a bit ad-hoc. Option #4: let people who want ultimate cache control use something else than zope.browserresource for serving static files. Feels a bit unfriendly (but Zope 3/Bluebream is usually pretty unfriendly...) Marius Gedminas -- http://pov.lt/ -- Zope 3/BlueBream consulting and development signature.asc Description: Digital signature ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
