Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-05-17 Thread Chris McDonough
On Mon, 2004-05-17 at 13:00, Dieter Maurer wrote: > Chris McDonough wrote at 2004-5-15 13:04 -0400: > > ... > >Dieter, do you think you can read this patch and give a thumbs up or > >down on it? > > The patch looks good. Great, thanks for looking at it. - C __

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-05-17 Thread Dieter Maurer
Chris McDonough wrote at 2004-5-15 13:04 -0400: > ... >Dieter, do you think you can read this patch and give a thumbs up or >down on it? The patch looks good. >On a different subject, the publisher probably shouldn't pass around >traceback objects (e.g. when it calls into err_hook) as Tres believ

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-05-15 Thread Chris McDonough
On Fri, 2004-05-14 at 22:49, Michael Dunstan wrote: > hmm... I suspect there are few holes in this... > > - Need to make sure there is no get_transaction().begin() in > zpublisher_exception_hook() of lib/python/Zope/App/startup.py > >That begin() would mean that the error handling is not i

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-05-14 Thread Michael Dunstan
On 14/05/2004, at 10:06 AM, Chris McDonough wrote: I am tempted to check the following into the 2.7 branch and HEAD: - "error occurs in same transaction as main request" patch to Publish.py. See http://www.plope.com/Members/chrism/ publishpy_errorinmaintrainsaction.patch/file_view for the patc

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-05-13 Thread Chris McDonough
Largely due to Michael I believe I have isolated and fixed every reported sessioning error except this (still-difficult-to-reproduce-but-definitely-still-existing) KeyError bug in temporary storage. I can let the test rig run for several hours; it happens maybe once every hour or two, so I've not

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-05-13 Thread Chris McDonough
On Wed, 2004-05-12 at 22:54, Michael Dunstan wrote: > On 11/05/2004, at 4:54 PM, Chris McDonough wrote: > > > On Mon, 2004-04-26 at 18:34, Michael Dunstan wrote: > >> I removed all the above hacks leaving just the > >> one that comments out the construction of the to_notify list. Reran > >> the >

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-05-12 Thread Michael Dunstan
On 11/05/2004, at 4:54 PM, Chris McDonough wrote: On Mon, 2004-04-26 at 18:34, Michael Dunstan wrote: I removed all the above hacks leaving just the one that comments out the construction of the to_notify list. Reran the test rig. And have yet to see any KeyErrors. Have you seen any since the tim

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-05-11 Thread Chris McDonough
On Tue, 2004-05-11 at 13:04, Dieter Maurer wrote: > Hi Chris, > > Chris McDonough wrote at 2004-5-11 00:54 -0400: > > ... > >So what do folks think of this error-case transaction isolation patch? > >Michael's original patch is preserved here (although it didn't survive > >cut and paste from my ma

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-05-11 Thread Dieter Maurer
Hi Chris, Chris McDonough wrote at 2004-5-11 00:54 -0400: > ... >So what do folks think of this error-case transaction isolation patch? >Michael's original patch is preserved here (although it didn't survive >cut and paste from my mail client in a pristine way, you'll get the >idea): > >http://ww

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-05-10 Thread Chris McDonough
Whew. I finally got a chance to review at least a bit of Michael's excellent work... On Mon, 2004-04-26 at 18:34, Michael Dunstan wrote: > Okay - I've gone ahead and implemented a flavour of transaction > isolation for errors. (See below for patch.) That seems to have done > the trick just ni

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-04-26 Thread Michael Dunstan
On 11/03/2004, at 7:25 PM, Chris McDonough wrote: On Wed, 2004-03-10 at 23:14, michael wrote: Thanks for your excellent isolation here. I don't get a KeyError thrown until *after* at least one rendering of standard_error_message that includes an access to a session variable. And I'm only getting

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-12 Thread Dieter Maurer
Chris McDonough wrote at 2004-3-11 23:56 -0500: >On Thu, 2004-03-11 at 07:29, Toby Dickenson wrote: > >> I have applications that send emails in error handlers. MailHost isnt >> transactional today, but Ive always wanted it to be. > >I suppose that's true. If someone else doesn't do it first, dur

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-11 Thread Chris McDonough
On Thu, 2004-03-11 at 07:29, Toby Dickenson wrote: > I have applications that send emails in error handlers. MailHost isnt > transactional today, but Ive always wanted it to be. I suppose that's true. If someone else doesn't do it first, during the bug day we'll try to support this use case, th

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-11 Thread Chris McDonough
On Thu, 2004-03-11 at 08:32, [EMAIL PROTECTED] wrote: > Hi Chris, > > On Tue, 9 Mar 2004, Chris McDonough wrote: > > > > But it seems I forget to install new Transience module to the new Zope > > > instance. Should I? > > Yes, please! > > Sorry, it does not seems to work on my first attempt:

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-11 Thread alex
Hi Chris, On Tue, 9 Mar 2004, Chris McDonough wrote: > > But it seems I forget to install new Transience module to the new Zope > > instance. Should I? > Yes, please! Sorry, it does not seems to work on my first attempt: Traceback (innermost last): * Module ZPublisher.Publish, line 163,

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-11 Thread Toby Dickenson
On Thursday 11 March 2004 12:19, Chris McDonough wrote: > > What if you want to make a change in the error handler? > > If anyone had been depending on this behavior in their current error > handlers, they would have seen weirdnesses in their applications like > those being reported now. I have a

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-11 Thread Chris McDonough
On Thu, 2004-03-11 at 06:52, Chris Withers wrote: > Well, what if you want to make a note in some object (say the error_log), that > something bad happened? The error_log doesn't use persistent objects to keep its messages. > What if you want to make a change in the error handler? If anyone ha

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-11 Thread Chris Withers
Chris McDonough wrote: I think the transaction in which the error code operates in should be aborted. Well, what if you want to make a note in some object (say the error_log), that something bad happened? What if you want to make a change in the error handler? My view is that the error handler

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-10 Thread michael
On 11/03/2004, at 7:25 PM, Chris McDonough wrote: On Wed, 2004-03-10 at 23:14, michael wrote: Thanks for your excellent isolation here. I don't get a KeyError thrown until *after* at least one rendering of standard_error_message that includes an access to a session variable. And I'm only getting

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-10 Thread Chris McDonough
On Wed, 2004-03-10 at 23:14, michael wrote: Thanks for your excellent isolation here. > I don't get a KeyError thrown until *after* at least one rendering of > standard_error_message that includes an access to a session variable. > And I'm only getting KeyError's for sessions that have had a

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-10 Thread michael
On 11/03/2004, at 1:07 PM, Chris McDonough wrote: On Wed, 2004-03-10 at 18:30, michael wrote: On closer inspection I have another small detail - I'm only seeing these KeyError's for sessions that have had a chance to expire and when trying to access the session from standard_error_message. Can y

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-10 Thread Chris McDonough
On Wed, 2004-03-10 at 18:30, michael wrote: > On closer inspection I have another small detail - I'm only seeing > these KeyError's for sessions that have had a chance to expire and when > trying to access the session from standard_error_message. Can you provide a complete traceback for the erro

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-10 Thread michael
On 11/03/2004, at 11:48 AM, Chris McDonough wrote: On Wed, 2004-03-10 at 15:20, Dieter Maurer wrote: michael wrote at 2004-3-10 15:22 +1300: ... I have been trying on and off to recreate this error via brute force loading of the simplest possible site that uses sessions. I failed to see this parti

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-10 Thread Chris McDonough
Nevermind. http://zope.org/Collectors/Zope/789 and http://zope.org/Collectors/Zope/786 The bug neglector is really living up to its name lately (not pointing fingers, mea culpa). - C On Wed, 2004-03-10 at 15:20, Dieter Maurer wrote: > michael wrote at 2004-3-10 15:22 +1300: > > ... > >I have

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-10 Thread Chris McDonough
On Wed, 2004-03-10 at 15:20, Dieter Maurer wrote: > michael wrote at 2004-3-10 15:22 +1300: > > ... > >I have been trying on and off to recreate this error via brute force > >loading of the simplest possible site that uses sessions. I failed to > >see this particular KeyError *until* I tried read

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-10 Thread Dieter Maurer
michael wrote at 2004-3-10 15:22 +1300: > ... >I have been trying on and off to recreate this error via brute force >loading of the simplest possible site that uses sessions. I failed to >see this particular KeyError *until* I tried reading a session variable >from standard_error_message. Now I

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-09 Thread michael
On 10/03/2004, at 6:29 AM, Chris McDonough wrote: On Tue, 2004-03-09 at 06:36, Alex V. Koval wrote: I have enabled 400 error_log ex exceptions to keep, and during 3 days I got 2 errors on the site: TimeUsername (User Id) Exception 16:35:01Anonymous User (None) KeyError:

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-09 Thread Chris McDonough
On Tue, 2004-03-09 at 06:36, Alex V. Koval wrote: > I have enabled 400 error_log ex exceptions to keep, and during 3 days I > got 2 errors > on the site: > > Time Username (User Id) Exception > 16:35:01 Anonymous User (None) KeyError: 1078763620 > 21:59:05 Anonymous

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-09 Thread Alex V. Koval
Hi Chris, On Fri, 05 Mar 2004 13:08:01 -0500, Chris McDonough <[EMAIL PROTECTED]> wrote: I am monitoring site now, and will tell you about the results. OK, many thanks! Running For: 3 days 4 hours 28 min 29 sec. I have enabled 400 error_log ex exceptions to keep, and during 3 days I got 2 er

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-05 Thread Chris McDonough
On Fri, 2004-03-05 at 09:15, [EMAIL PROTECTED] wrote: > Installed. I had to install new zope instance first, then import > old content via zexp & recreate manually all admins. Because when you > change the running zope config in Zope 2.7.0 it has no impact on > temp_folder - Sessions.fs is not cr

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-05 Thread alex
Hi Chris, On Wed, 3 Mar 2004, Chris McDonough wrote: > With this text: > > > # Temporary storage database (for sessions) > > path $INSTANCE/var/Sessions.fs > > mount-point /temp_folder > container-class Products.TemporaryFolder.TemporaryContainer > Installed. I ha

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-04 Thread Chris McDonough
On Wed, 2004-03-03 at 22:53, John Belmonte wrote: > If I'm following this thread correctly, isn't the code failing because > the BTree is corrupted (that is, BTrees.check.check chokes)? If that's > the case then you're certainly right to avoid masking the problem. We don't know that it's corrup

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-04 Thread John Belmonte
Chris McDonough wrote: On Wed, 2004-03-03 at 22:20, Casey Duncan wrote: for key in list(self._data.keys(None, max_ts)): assert(key <= max_ts) STRICT and _assert(self._data.has_key(key)) for v in self._data[key].values(): to_notify.append(v)

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-03 Thread Chris McDonough
On Wed, 2004-03-03 at 22:20, Casey Duncan wrote: > > > for key in list(self._data.keys(None, max_ts)): > > > assert(key <= max_ts) > > > STRICT and _assert(self._data.has_key(key)) > > > for v in self._data[key].values(): > > > to_notify.a

Re: [ZODB-Dev] Re: BTrees strangeness (was [Zope-dev] Zope 2.X BIG Session problems - blocker - our site dies - need help of experience Zope developer, please)

2004-03-03 Thread Jeremy Hylton
On Wed, 2004-03-03 at 04:55, Chris McDonough wrote: > (boldly crossposting this to zodb-dev, please respond on one list or the > other but not both) > > That error *appears* to be caused by reaching a state that is impossible > to reach. The code in question is: > > for key in list(self.