Chris Hillery has proposed merging lp:~zorba-coders/zorba/fots-ctest into
lp:zorba.
Commit message:
CTest integration for FOTS driver. Allows automated import of FOTS, and
enabling one CTest test per FOTS test set *or* per FOTS test case.
Requested reviews:
Sorin Marian Nasoi
Sorin: Take a look at test/fots/README.TXT for an explanation of the
integration I've done. Please try it out and let me know if you have problems.
I don't think this is ready for merge yet since there is no integration with
EXPECTED_FAILURE() or anything like it, which is why I haven't voted
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/138054
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/138054
Your team
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2012-12-05T15-06-05.62Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/138054
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
A couple questions:
1. Can the result= attribute of a test-case in FOTS driver output have
values other than pass or fail? Currently I am determining whether a CTest
test passes based on this output.
I tried to make the default output of FOTS driver the exact thing needed for a
W3C
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/138054
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/138054
Your team
The attempt to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba failed. Below
is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job pjl-misc-2012-12-05T15-06-05.62Z is finished. The
final status
Cezar Andrei has proposed merging
lp:~zorba-coders/zorba/bug1086323-processExitCode into lp:zorba/process-module.
Requested reviews:
Sorin Marian Nasoi (sorin.marian.nasoi)
Paul J. Lucas (paul-lucas)
Chris Hillery (ceejatec)
Related bugs:
Bug #1086323 in Zorba: Process module: exit code
Using the usual exit codes convention, as per our todays' talk.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The proposal to merge lp:~zorba-coders/zorba/bug1086323-processExitCode into
lp:zorba/process-module has been updated.
Commit Message changed to:
Fix for bug 1086323, align Fedora and Ubuntu when process module executes a
command that crashes.
For more details, see:
The proposal to merge lp:~zorba-coders/zorba/bug1086323-processExitCode into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1086323-processExitCode-2012-12-05T17-36-43.652Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch
The attempt to merge lp:~zorba-coders/zorba/bug1086323-processExitCode into
lp:zorba/process-module failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job
The proposal to merge lp:~zorba-coders/zorba/bug1086323-processExitCode into
lp:zorba/process-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
--
Chris claims the RQ is fixed now.
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/138054
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/bug1086323-processExitCode into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1086323-processExitCode-2012-12-05T18-10-35.842Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch
Review: Needs Fixing
The module comments still list the -2000 / -1000 return value numbers.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list:
Paul (not sure if you were on the conf call today) : we decided that we should
fix just this problem in the process module for now, to allow it to
consistently report exit status across Linux distributions and hopefully MacOS.
As for the other issues you and I raised, I will file new bugs which
It would be great if you could test this on MacOS, and vote Approve if there
are no other issues.
I could test it if there were a test I could run.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch
Validation queue job bug1086323-processExitCode-2012-12-05T18-10-35.842Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Needs Fixing, 2 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch
The proposal to merge lp:~zorba-coders/zorba/bug1086323-processExitCode into
lp:zorba/process-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
--
Review: Approve
I have checked on Fedora and these are the returned codes:
- if a test ends in a SEG FAULT = exit-code = 139
- if a test reaches an ASSERT = exit code = 134
So I approve this proposal but at least someone on Ubuntu (ideally also on
MacOS) should confirm that they get the same
Fixed xqdoc.
Also I tested it on Ubuntu, segfault comes with exit code 139.
To test it one needs to call process:exec on a program that ends with a
segmentation fault.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is
Matthias Brantner has proposed merging
lp:~zorba-coders/zorba/feature-reference_module into lp:zorba.
Commit message:
Added new module (http://www.zorba-xquery.com/modules/references) for
(de)referencing nodes and json objects.
Requested reviews:
Matthias Brantner (matthias-brantner)
For
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/feature-reference_module/+merge/138345
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/feature-reference_module into
lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-reference_module/+merge/138345
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-reference_module-2012-12-06T00-11-53.561Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/feature-reference_module/+merge/138345
Your team Zorba Coders is subscribed to branch
Validation queue job feature-reference_module-2012-12-06T00-11-53.561Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/feature-reference_module/+merge/138345
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve, 2 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/feature-reference_module/+merge/138345
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
The proposal to merge lp:~zorba-coders/zorba/feature-reference_module into
lp:zorba has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-reference_module/+merge/138345
--
Review: Approve
Verified (with Sorin's repro script in email) that this works on Ubuntu.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list:
Matthias Brantner has proposed merging lp:~zorba-coders/zorba/bug-1073978 into
lp:zorba.
Commit message:
fix for bug #1073978 (FOTS: option default ns not supported)
Requested reviews:
Matthias Brantner (matthias-brantner)
Related bugs:
Bug #1073978 in Zorba: FOTS: option default ns not
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-1073978-2012-12-06T01-19-40.619Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1073978/+merge/138355
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
On Mac OS X 10.8.2, it prints:
139 0
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
After discussion with Chris, I'm approving this despite it not working on Mac
OS X since the short-term goal is to have this working on Linux where having it
working on Mac OS X is a nice-to-have.
The test that was supposed to SEGFAULT did; the test that was supposed to have
The proposal to merge lp:~zorba-coders/zorba/bug1086323-processExitCode into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
--
Follow-up: after running a new query to call a C program:
#include stdlib.h
int main() {
abort();
}
it prints 134. Hence, the process-module fix works but the HOF code behaves
differently on Mac OS X.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
The attempt to merge lp:~zorba-coders/zorba/bug-1073978 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug-1073978-2012-12-06T01-19-40.619Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/bug-1073978 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1073978/+merge/138355
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1086323-processExitCode-2012-12-06T01-48-38.697Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch
Validation queue job bug1086323-processExitCode-2012-12-06T01-48-38.697Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
The proposal to merge lp:~zorba-coders/zorba/bug1086323-processExitCode into
lp:zorba/process-module has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
--
Of the failing tests, only some have been modified. If you changed the default
behavior, shouldn't you also have to change every affected test by adding the
pragma?
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044
Your team Zorba Coders is subscribed to branch
45 matches
Mail list logo
