Ghislain, I've fixed the null/true/false etc and select issues (points 5 and
8).
--
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
1. Parser.y, line 2259: is || (block != NULL block-isEmpty()) really
needed? Will block not always be null if a BlockExpr is {} (see
StatementsAndOptionalExpr nonterminal)?
Nope, you can have a nested empty block {{}}.
2. Why is the OBJECT token treated specially and not mentioned in
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183479
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183479
The proposal to merge lp:~nbrinza/zorba/trunk-test into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/trunk-test/+merge/183495
--
https://code.launchpad.net/~nbrinza/zorba/trunk-test/+merge/183495
Your team Zorba
Nicolae Brinza has proposed merging lp:~nbrinza/zorba/trunk-test into lp:zorba.
Commit message:
Test merge.
Requested reviews:
Nicolae Brinza (nbrinza)
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/trunk-test/+merge/183495
Test merge.
--
https://code.launchpad.net
The proposal to merge lp:~nbrinza/zorba/trunk-test into lp:zorba has been
updated.
Status: Merged = Rejected
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/trunk-test/+merge/183495
--
https://code.launchpad.net/~nbrinza/zorba/trunk-test/+merge/183495
Your team Zorba
The proposal to merge lp:~nbrinza/zorba/trunk-test2 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504
--
https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504
Your team
Nicolae Brinza has proposed merging lp:~nbrinza/zorba/trunk-test2 into lp:zorba.
Commit message:
Test merge.
Requested reviews:
Nicolae Brinza (nbrinza)
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504
Test merge.
--
https://code.launchpad.net
The proposal to merge lp:~nbrinza/zorba/trunk-test2 into lp:zorba has been
updated.
Status: Approved = Rejected
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504
--
https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504
Your team Zorba
The proposal to merge lp:~nbrinza/zorba/trunk-test2 into lp:zorba has been
updated.
Status: Rejected = Approved
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504
--
https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504
Your team Zorba
The proposal to merge lp:~nbrinza/zorba/trunk-test2 into lp:zorba has been
updated.
Status: Approved = Rejected
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504
--
https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504
Your team Zorba
The proposal to merge lp:~nbrinza/zorba/error-messages into lp:zorba has been
updated.
Commit Message changed to:
Fixed bugs #1210320 and #1212423 - misplaced compiler error
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/181327
--
Paul, I've also addressed your comments on the merge proposal.
--
--
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
I have fixed issues 1 through 3.
Regarding point 4: your approach, if I understood it correctly, will only build
the dataflow information, but not the dataguide itself. To compute it, it would
require an additional pass through the expression tree and an additional data
structure.
Regarding
I've fixed the crash and added the query as zorba/eval/eval16.xq.
--
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
I don't understand why. In my example it wouldn't. The count functions could
count
the number of empty objects or objects that contain only the STREET field.
I've looked into the test and here are the issues:
1) The fn:count() does not have the %explores-json annotation. I've confused it
with
Ok, it wasn't too much work -- I've added a special handler for fn:count() in
the dataguide code and now the example you gave prunes all the fields except
price.
--
--
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Your team Zorba Coders is subscribed to branch
I meant the STREET field. I've used price in the testcase.
--
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
I have no idea what problem this MP is supposed to solve; nor do I know what a
data guide is.
Paul, I've made some changes to the JSON loader so that it skips creating nodes
that are not in a given template (== dataguide). Since you've written the
loader, could you please review only the
The way I see this is not a problem with the fn functions. The problem is
related to the fact how the objects are used. In this case, the objects are
used to construct a new object. The dataguide needs to handle that. Similar to
serialization, this means that the entire object is needed.
Yes,
I have tried some basic queries and there is a huge performance improvement.
This is great.
However, I detected a memory leak and have one question.
- memory leak in translator.cpp:4823
I've fixed it.
- In the following query, no dataguide seems to be pushed into the parser.
Why?
The
- In ZorbaCollectionIterator::initCollection lines 307 and 326, you eventually
add skipCount twice. Something smells spooky here.
Yes, it seems it was added twice. I've fixed it.
I've also added the skip() function to the EvalIterator.
--
--
I've looked into the index probe iterators but they already optimize any
skipping. They take a Skip parameter and then they push it into an underlying
iterator e.g. ProbeValueTreeIndexIterator which handles the skip internally. So
there is nothing to be done there.
I've pushed the pending
I've done some additional testing, and these are the results:
For the xray query, the largest that we have in the testsuite, compilation time
with --compile-only is pretty much the same with and without the dataguide
computaiton, at around ~0.08 sec.
With a specially constructed query that
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
- Shouldn't skip take an unsigned integer?
The parameters to fn:subsequence and co are all signed. E.g. you can pass a
negative skip.
- Why is the while loop in collections_impl.cpp:397 necessary if
initCollection is called before? I think there might be a bug in
initCollection.
DataGuides serve as dynamic schemas, generated from the database. What we
generate is a
schema from the query.
Still, it is a data schema, not a query schema. The one in the paper would be a
Database DataGuide and ours would be Query DataGuide. I would agree to change
it to
- I find the name dataguide misleading because it's a guide on the query and
not on the data. Maybe QueryPruneGuide would be more meaningful
The query itself is not pruned, the data is. I think dataguide is the
established term -- see for example this paper:
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/dataguide/+merge/173026
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/skip-items into
lp:zorba.
Commit message:
Implemented the Skip-items facility
Requested reviews:
Nicolae Brinza (nbrinza)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Implemented
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
--
The proposal to merge lp:~zorba-coders/zorba/dataguide into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/dataguide/+merge/173026
--
https://code.launchpad.net/~zorba-coders/zorba/dataguide/+merge/173026
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Commit Message changed to:
Changed module's errors to the new modules guidelines; Potential fix for
execvpe() on Macs
For more details, see:
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module.
Commit message:
Changed module's errors to the new modules guidelines; Potential fix for
execvpe() on Macs
Requested reviews:
Nicolae Brinza (nbrinza)
Ghislain Fourny (gislenius)
Related bugs
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
--
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
--
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
--
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
I've merged Paul's change -- it was only a one line change.
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167907
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167907
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167907
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167907
The proposal to merge lp:~zorba-coders/zorba/array-unboxing into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/array-unboxing/+merge/168099
--
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824
For some reason, the commits to my checked-out branch are not pushed
automatically, and I forgot to do it manually. It is pushed now.
I've also fixed all issues you reported except for the namespace change to
zorba.io. As far as I understood, it will be done for all modules at once --
it is
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1182910/+merge/167369
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Matthias,
They URI messages won't appear anymore, but I've done it by calling abort()
instead of exit() in the child fork() in the process module, because:
-- it will keep the Zorba URIs leaks messages in the Release build
-- the exit code in the case of an error is lost anyway due to the
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
--
I've fixed all the issues except for the leaks problem. I have not removed the
printing of the URIs because it would disable them for the entire Zorba engine.
Even if the messages are removed there is still the problem of the exit code,
which cannot be fixed easily now.
--
--
Regarding the referenced URI messages -- these are indeed coming from the
StringPool as leaked entries. When the main process is fork()'ed, the child
process is basically a copy of the parent process with all the statically
allocated objects duplicated. When the child process calls exit(),
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module.
Commit message:
Version 2.0 of the process module, allows running executables directly, without
invoking bash/cmd.exe
Requested reviews:
Nicolae Brinza (nbrinza)
Matthias Brantner (matthias
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module.
Commit message:
Version 2.0 of the process module, allows running executables directly, without
invoking bash/cmd.exe
Requested reviews:
Nicolae Brinza (nbrinza)
Matthias Brantner (matthias
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Commit Message changed to:
Version 2.0 of the process module, allows running executables directly, without
invoking bash/cmd.exe
For more details, see:
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
--
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/new-exec into
lp:zorba.
Commit message:
Modified files that use the process module to request version 1.0, in
preparation of the new version of the module.
Requested reviews:
Nicolae Brinza (nbrinza)
Matthias Brantner (matthias
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/new-exec/+merge/164166
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/new-exec into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-exec/+merge/164166
--
https://code.launchpad.net/~zorba-coders/zorba/new-exec/+merge/164166
Your
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/null-type-fix/+merge/163883
Your team Zorba Coders is subscribed to branch
lp:~zorba-coders/zorba/new-jsoniq.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/null-type-fix/+merge/163902
Your team Zorba Coders is subscribed to branch
lp:~zorba-coders/zorba/new-jsoniq.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
I've added a mention in the ChangeLog
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Approved = Rejected
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Rejected = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Done
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Yeah, I just fixed that unit test as well...
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Matthias, your suggestions for two improved warnings do not change the
messages: you just switched the order of the words. The warnings are built
around the template:
feature not supported by the common language grammar{: $1}
So it is not easy to make this swap. I could probably do it,
Why would you need a qualified value if the option itself is already
qualified?
I guess because the option name and the option value may not live in the same
namespace.
Why not? It's not as if you do schema validation on the options and their
values. The option needs to be qualified to
(by the way, character entity references do not exist in XML. There are
character references (#...;) and entity references (...;), but not both at
the same time if I am correct :-) )
Indeed you're right. I trusted Wikipedia which uses the term character entity
references and says ``The XML
Fixed all the raised issues.
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/bug-1176038 into
lp:zorba.
Commit message:
Fixed a bug in the parser that was revealed by bison 2.7 + #include clean-up
Requested reviews:
Nicolae Brinza (nbrinza)
Paul J. Lucas (paul-lucas)
Related bugs:
Bug #1176038 in Zorba
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1176038/+merge/162953
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/bug-1176038 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1176038/+merge/162953
--
1 - 100 of 478 matches
Mail list logo