Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-error_printer_in_api/+merge/134405
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/zorba-error_printer_in_api into
lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/zorba-error_printer_in_api/+merge/134405
--
https://code.launchpad.net/~zorba-coders
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/zorba-error_printer_in_api-2013-02-07T00-11-30.914Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-error_printer_in_api/+merge/134405
Your team Zorba Coders is subscribed to branch
The proposal to merge lp:~zorba-coders/zorba/zorba-error_printer_in_api into
lp:zorba has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/zorba-error_printer_in_api/+merge/134405
--
https://code.launchpad.net/~zorba-coders
The proposal to merge lp:~zorba-coders/zorba/zorba-error_printer_in_api into
lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/zorba-error_printer_in_api/+merge/134405
--
https://code.launchpad.net/~zorba-coders
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/zorba-error_printer_in_api-2013-02-07T01-32-31.231Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-error_printer_in_api/+merge/134405
Your team Zorba Coders is subscribed to branch
The proposal to merge lp:~zorba-coders/zorba/zorba-error_printer_in_api into
lp:zorba has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/zorba-error_printer_in_api/+merge/134405
--
https://code.launchpad.net/~zorba-coders/zorba
Actually, in the short term, I'd like to revert the way the error code is
printed to:
codeerr:XPST0003/code
and merge the branch into the trunk immediately because this branch actually
makes testing the branch for bug 786 much easier. I'll file a separate bug
to change the form to:
Also, does the 28msec code rely on the kind being like:
kindstatic error/kind
or will:
kindstatic/kind
still work?
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-error_printer_in_api/+merge/134405
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The error code was printed in XML as:
codeerr:XPST0003/code
I think it's better to print it as:
codehttp://www.w3.org/2005/xqt-errors#XPST0003/code
(as suggested in http://www.w3.org/TR/xquery-30/#id-identifying-errors).
But is it better still to print it as:
code
The error code was printed in XML as:
codeerr:XPST0003/code
I think it's better to print it as:
codehttp://www.w3.org/2005/xqt-errors#XPST0003/code
(as suggested in http://www.w3.org/TR/xquery-30/#id-identifying-errors).
But is it better still to print it as:
code
It would make sense to me but the problem is that the change is not backwards
compatible.
I know that 28msec relies on it.
on the current way the error is reported.
There were other mistakes that whoever coded the original XML made. For
example, not including a xmlns=... attribute on the
I've done a lot of clean-up. You have the basic implementation correct. I've
moved several functions inline. I've moved the printing of the stack trace
constants to XQueryException since only XQueryException has stack traces. I've
added doxygen comments that you didn't.
Why don't you
I just checked: ZorbaException already has a global
operator(ostream,ZorbaException const) function defined for it.
So why do you need to do anything at all?
Hi Paul, sorry for not following up for a long time. We just need it to get the
errors in xml format. I guess this is not supported in
Cool, now I can fix what someone else did wrong :-(.
Anyway, Paul, can you help me on one thing please? Can you tell me how I can
use this ErrorPrinter for warnings too?
It's a stupid API. There's no reason to have a class with a single static
member function. If you're going to make it
Anyway, Paul, can you help me on one thing please? Can you tell me how I can
use this ErrorPrinter for warnings too?
An XQueryWarning is just a typedef for XQueryException, so it should just work
as-is.
That aside: generally, I don't like to decide for the user how errors should be
printed.
I just checked: ZorbaException already has a global
operator(ostream,ZorbaException const) function defined for it.
So why do you need to do anything at all?
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-error_printer_in_api/+merge/134405
Your team Zorba Coders is subscribed to branch
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-error_printer_in_api/+merge/134405
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
I approve but I want to make sure the same or similar functionality (maybe
without XML printing) is not already available in the API. Hence, I added Paul.
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-error_printer_in_api/+merge/134405
Your team Zorba Coders is
Review: Disapprove
It's a stupid API. There's no reason to have a class with a single static
member function. If you're going to make it public, it needs to be better.
Two things come to mind:
1. (Trivial) Simply make it a global function -- no need for a class.
2. (Less trivial) Create a
David Graf has proposed merging
lp:~zorba-coders/zorba/zorba-error_printer_in_api into lp:zorba.
Commit message:
Moving the error printer from zorbacmd into the api.
Requested reviews:
Matthias Brantner (matthias-brantner)
William Candillon (wcandillon)
For more details, see:
The proposal to merge lp:~zorba-coders/zorba/zorba-error_printer_in_api into
lp:zorba has been updated.
Commit Message changed to:
Moving the error printer from zorbacmd into the api.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/zorba-error_printer_in_api/+merge/134405
It would be good to use this error printer for the warning reporter too. But I
didn't figure out how that should work yet? Can you guys help?
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-error_printer_in_api/+merge/134405
Your team Zorba Coders is subscribed to branch lp:zorba.
--
23 matches
Mail list logo
