> The implementation of getExternalVariables in the xqueryimpl level is done.
Juan, I fixed the implementation of the XQuery::getExternalVariables() method.
The main problem there was that you were comparing QName items using their
string value. This is not correct because the string value of a
> Done just changed the ownership to zorba-coders
>
> > Juan, can you please make zorba-coders be the owner of this branch. I want
> to
> > make some changes to it, but I cannot because it currently belongs to you
> > only.
Hmm, I couldn't find it. what is the new name of the branch?
--
https://
Done, just changed the ownership to zorba-coders
2011/11/1 Markos Zaharioudakis
> Juan, can you please make zorba-coders be the owner of this branch. I want
> to make some changes to it, but I cannot because it currently belongs to
> you only.
> --
> https://code.launchpad.net/~juan457/zorba/xqx
Done just changed the ownership to zorba-coders
> Juan, can you please make zorba-coders be the owner of this branch. I want to
> make some changes to it, but I cannot because it currently belongs to you
> only.
--
https://code.launchpad.net/~juan457/zorba/xqxq-api-changes/+merge/79589
Your team
Juan, can you please make zorba-coders be the owner of this branch. I want to
make some changes to it, but I cannot because it currently belongs to you only.
--
https://code.launchpad.net/~juan457/zorba/xqxq-api-changes/+merge/79589
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Ma
The implementation of getExternalVariables in the xqueryimpl level is done.
--
https://code.launchpad.net/~juan457/zorba/xqxq-api-changes/+merge/79589
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.la
Hi markos,
So I made some changes to do what you told me to, but have some problems
checking if it works, since a simple case of just using an external variable
like
declare $a external;
$a
works correctly, but in all my examples theCompilerCB->theSctxMap has just 1
Sctx in the map, so I tri
> > Second, to get the external variables from all the modules that participate
> in
> > a query, we also need a getExternalVariables() at the XQueryImpl level. This
> > method will go through all the static context objs in
> > theCompilerCB->theSctxMap and compute the union of the external variabl
> Second, to get the external variables from all the modules that participate in
> a query, we also need a getExternalVariables() at the XQueryImpl level. This
> method will go through all the static context objs in
> theCompilerCB->theSctxMap and compute the union of the external variables
> retur
Ok, it looks better now, but we are not done yet
First, the comment in include/zorba/static_context.h for the
getExternalVariables() method is wrong. The method returns the qnames of all
the external variables that are in-scope within that static context. It's not
about whether the variable
Done I changed the getExternalVariables to the staticContext.
--
https://code.launchpad.net/~juan457/zorba/xqxq-api-changes/+merge/79589
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Un
Juan, the getExternalVariables method should be part of the static context, not
the dynamic context.
Probably the easiest way to implement this is to add an "externalOnly" param to
the static_context::getVariables method and then add a getExternalVariables
method in StaticContextImpl, which wil
Last minor stylistic comments from me:
- std::vector::iterator lIte =>
std::vector::const_iterator lIte
- if(program ->is_sequential()) => if (program->is_sequential())
--
https://code.launchpad.net/~juan457/zorba/xqxq-api-changes/+merge/79589
Your team Zorba Coders is subscribed to branch lp:
changes done
> Yes, the zorba/ChangeLog file should mention bug fixes and such extensions.
>
> Also, the tests themselves look good but you should compare for the expected
> result. For example, whether isSequential really returns true (instead of just
> outputting it).
--
https://code.launchpad
Review: Needs Fixing
Yes, the zorba/ChangeLog file should mention bug fixes and such extensions.
Also, the tests themselves look good but you should compare for the expected
result. For example, whether isSequential really returns true (instead of just
outputting it).
--
https://code.launchpad
I added the test in the test/unit/cxx_api_changes.cpp just one question, what
you mena by mention my changes in ChangeLog, you mean in zorba/Changelog or did
I miss in bazaar something?
> Juan, could you please also provide some tests? The best places would either
> be doc/cxx/examples/contex
Review: Needs Fixing
Juan, could you please also provide some tests? The best places would either be
doc/cxx/examples/context.cpp or test/unit/. Examples in the former file are
mostly used for documentation purposes because those examples are linked from
the web site. The latter directory conta
Juan Zacarias has proposed merging lp:~juan457/zorba/xqxq-api-changes into
lp:zorba.
Requested reviews:
Markos Zaharioudakis (markos-za)
For more details, see:
https://code.launchpad.net/~juan457/zorba/xqxq-api-changes/+merge/79589
C++ API changes:
Implementation of getExternalVariables func
18 matches
Mail list logo
