I've looked into the index probe iterators but they already optimize any
skipping. They take a Skip parameter and then they push it into an underlying
iterator e.g. ProbeValueTreeIndexIterator which handles the skip internally. So
there is nothing to be done there.
I've pushed the pending
I've done some additional testing, and these are the results:
For the xray query, the largest that we have in the testsuite, compilation time
with --compile-only is pretty much the same with and without the dataguide
computaiton, at around ~0.08 sec.
With a specially constructed query that
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Your team
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Stage BuildZorbaUbuntu failed.
Check compiler output at
http://jenkins.lambda.nu/job/BuildZorbaUbuntu/122/parsed_console to view the
results.
--
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Your team
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Your team
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385 :
Votes: {'Approve': 1, 'Pending': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Your team Zorba Coders is subscribed to branch
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Stage CommitZorba failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/47/console to
view the results.
--
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/pjl-misc into lp:zorba.
Commit message:
Added operator for enums; moved to .cpp.
Requested reviews:
Paul J. Lucas (paul-lucas)
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/176445
Added operator for
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/176445
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Your team
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/176445
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/176445
Your team
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/176445
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/176445
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/176445
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/176445
Your team Zorba Coders is
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Stage CommitZorba failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/48/console to
view the results.
--
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385 :
Votes: {'Approve': 1, 'Pending': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Your team Zorba Coders is subscribed to branch
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/176445
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/176445
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/176445
Your team Zorba
Review: Needs Fixing
In archive_module.cpp:
1. Please don't leave commented-out code. Just delete it; it's in the version
history if we ever need to refer back to it. For example, remove these lines:
+//Item lNameItem = theFactory-createString(lName);
+//lMemberName =
Review: Needs Fixing
Also, you have at least one /p typo in archive.xq.
Always remember to run
ctest -R moduleDocumentation
before committing, to be sure that your XQDoc is syntactically correct and that
you didn't forget to document any parameters, etc.
--
Review: Needs Information
Looks good to me. Only two issues.
- The thing with the probe iterators is that there are additional functions
called probe-*-skip that allow
you to skip explicitly. However, subsequence is not rewritten into these
functions. We will need to override the skip function
Review: Needs Fixing
I have tried some basic queries and there is a huge performance improvement.
This is great.
However, I detected a memory leak and have one question.
- memory leak in translator.cpp:4823
==20325== 88 (32 direct, 56 indirect) bytes in 1 blocks are definitely lost in
loss
24 matches
Mail list logo
