[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug924756-xsDateTimeStamp-2013-03-12T19-27-54.498Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job bug924756-xsDateTimeStamp-2013-03-12T19-27-54.498Z is finished. The final status was: 8 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug924756-xsDateTimeStamp-2013-03-13T01-17-05.513Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job bug924756-xsDateTimeStamp-2013-03-13T01-17-05.513Z is finished. The final status was: 3 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug924756-xsDateTimeStamp-2013-03-13T01-49-00.348Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Validation queue job bug924756-xsDateTimeStamp-2013-03-13T01-49-00.348Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Of 32 prod-SchemaImport cases: 3 - correct answer - xml comparator needs to be better qischema005 qischema032c qischema070 1 - resource not found qischema016 3 - castable bug qischema031 qischema040 qischema040a 17 - bug in testcase schema or Xerces nor implementing xsd1.1 substitution-001 substitution-002 substitution-003 substitution-004 substitution-005 substitution-006 substitution-007 substitution-008 substitution-009 substitution-010 substitution-011 substitution-020 substitution-021 substitution-022 substitution-023 substitution-024 substitution-025 8 - schema-element-head cbcl-schema-element-1 cbcl-schema-element-2 cbcl-schema-element-4 cbcl-schema-element-5 cbcl-schema-element-8 cbcl-validated-schema-element-1 cbcl-validated-schema-element-3 cbcl-validated-schema-element-4 -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Review: Approve Looks like modules/w3c/xpath_functions.xq already declares fn:current-dateTime() as xs:dateTimeStamp. While modules/w3c/xpath_functions.xq declares datetime:current-dateTime() as xs:dateTime. Verified FOTS/xs-dateTimeStamp tests are passing. Verified import module namespace schema = http://www.zorba-xquery.com/modules/schema;; schema:schema-type( fn:current-dateTime() ) returns xs:dateTimeStamp. -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug924756-xsDateTimeStamp-2013-02-27T12-23-49.716Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job bug924756-xsDateTimeStamp-2013-02-27T12-23-49.716Z is finished. The final status was: 4 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Cezar you did not update the expected_failures in test/fots/CMakeLists.txt according to your fixes. I will add a fix asap. -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
It seems that there are 2 regressions: - 1 in FOTS/xs-double test set, xs-float-003 test case - 1 in FOTS/xs-float, xs-double-003 test case I am looking into those now. -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
It seems that there are 2 regressions: - 1 in FOTS/xs-double test set, xs-float-003 test case - 1 in FOTS/xs-float, xs-double-003 test case I am looking into those now. Cezar, after you enabled the XSD 1.1 support in FOTSZorbaManifest.xml there are 2 test cases that regressed (before these test cases were reported as not applicable since XSD 1.1 dependency was not met). Both test cases refer to the same issue: +INF: value of type xs:string is not castable to type xs:float or xs:double. HTH, Sorin -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Additional info. : if you want to say we support XML version 1.1 I think we also have to say we support XML versions 1.0:5+ 1.1. This means the following setting in FOTSZorbaManifest.xml: [...] dependency type=xml-version value=1.0 satisfied=true/ dependency type=xml-version value=1.0:4- satisfied=true/ dependency type=xml-version value=1.0:5+ 1.1 satisfied=true/ dependency type=xml-version value=1.1 satisfied=true/ [...] Please see: https://bugs.launchpad.net/zorba/+bug/924754/comments/3 for the list of test cases that fail when the above change is made into FOTSZorbaManifest.xml. IMO we should decide between: - saying we support XML 1.1 and versions between XML 1.0:5 and 1.1: in this case we add the test cases as EXPECTED_FOTS_FAILURES and try to fix them - saying we do not support XML 1.1 and versions between XML 1.0:5 and 1.1 What do you guys think? -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Additional info. : if you want to say we support XML version 1.1 I think we also have to say we support XML versions 1.0:5+ 1.1. This means the following setting in FOTSZorbaManifest.xml: [...] dependency type=xml-version value=1.0 satisfied=true/ dependency type=xml-version value=1.0:4- satisfied=true/ dependency type=xml-version value=1.0:5+ 1.1 satisfied=true/ dependency type=xml-version value=1.1 satisfied=true/ [...] Please see: https://bugs.launchpad.net/zorba/+bug/924754/comments/3 for the list of test cases that fail when the above change is made into FOTSZorbaManifest.xml. IMO we should decide between: - saying we support XML 1.1 and versions between XML 1.0:5 and 1.1: in this case we add the test cases as EXPECTED_FOTS_FAILURES and try to fix them - saying we do not support XML 1.1 and versions between XML 1.0:5 and 1.1 What do you guys think? I set by mistake xml-version instead of XSD version: I will update the report. -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
I set xsd-version 1.1 support to true (and left only XML 1.0 support) and added the report of failing test cases in https://bugs.launchpad.net/zorba/+bug/924754. The following test cases fail: - 4 test cases fn-adjust-dateTime-to-timezone test set - 1 in fn-normalize-unicode test set - 1 in xs-double test set (+INF support) - 1 in xs-float test set (+INF support) - 32 in prod-SchemaImport test set At least one test case (from fn-normalize-unicode test set) is failing because there is no dependency defined for XML version 1.0. If indeed XML version 1.1 and XSD version 1.1 are orthogonal then this is a bug in FOTS. -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
I fixed the 2 +INF tests. -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Cezar Andrei has proposed merging
lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba.
Commit message:
Add support for xs:dateTimeStamp XMLSchema 1.1 built-in type.
Requested reviews:
Cezar Andrei (cezar-andrei)
Markos Zaharioudakis (markos-za)
Related bugs:
Bug #924754 in Zorba: support for the xs:dateTimeStamp type
https://bugs.launchpad.net/zorba/+bug/924754
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901
Add support for xs:dateTimeStamp XMLSchema 1.1 built-in type.
--
https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'include/zorba/store_consts.h'
--- include/zorba/store_consts.h 2012-12-05 03:33:46 +
+++ include/zorba/store_consts.h 2013-02-21 18:17:25 +
@@ -24,7 +24,7 @@
/***
!!! ATTENTION: The order of the enum values within SchemaTypeCode is important.
- !!! DO NOT change this order
+ !!! DO NOT change this order DO NOT insert in the middle
/
enum SchemaTypeCode
{
@@ -86,6 +86,7 @@
XS_NOTATION = 44,
JS_NULL = 45,
+ XS_DATETIME_STAMP= 46,
XS_LAST
};
=== modified file 'src/api/store_consts.cpp'
--- src/api/store_consts.cpp 2012-12-12 19:34:45 +
+++ src/api/store_consts.cpp 2013-02-21 18:17:25 +
@@ -70,6 +70,7 @@
xs:QNAME, // 43
xs:NOTATION,// 44
js:null,// 45
+xs:dateTimeStamp, // 46
};
if ( c = 0 c XS_LAST )
=== modified file 'src/store/api/item_factory.h'
--- src/store/api/item_factory.h 2013-02-12 04:20:23 +
+++ src/store/api/item_factory.h 2013-02-21 18:17:25 +
@@ -407,6 +407,50 @@
* @param xs:time Item (might be NULL)
*/
virtual bool createDateTime(Item_t result, const Item_t, const Item_t) = 0;
+
+
+ virtual bool createDateTimeStamp(
+ Item_t result,
+ const xs_dateTime* value) = 0;
+
+ virtual bool createDateTimeStamp(
+ store::Item_t result,
+ const xs_date* date,
+ const xs_time* time) = 0;
+
+
+ /**
+ * @param year
+ * @param month
+ * @param day
+ * @param hour
+ * @param minute
+ * @param second
+ * @param timeZone_hours Difference in hours to UTC
+ */
+ virtual bool createDateTimeStamp(
+ Item_t result,
+ short year,
+ short month,
+ short day,
+ short hour,
+ short minute,
+ double second,
+ short timeZone_hours) = 0;
+
+ /**
+ * Specification: [http://www.w3.org/TR/xmlschema11-2/#dateTimeStamp]
+ * @param value string representation of the value
+ */
+ virtual bool createDateTimeStamp(Item_t result, const char* str, ulong strlen) = 0;
+
+ /**
+ * Specification: [http://www.w3.org/TR/xpath-functions/] Section 5.2
+ *
+ * @param xs:date Item (might be NULL)
+ * @param xs:time Item (must not be NULL)
+ */
+ virtual bool createDateTimeStamp(Item_t result, const Item_t, const Item_t) = 0;
virtual bool createDate(Item_t result, const xs_date* value) = 0;
=== modified file 'src/store/naive/simple_item_factory.cpp'
--- src/store/naive/simple_item_factory.cpp 2013-02-18 14:54:25 +
+++ src/store/naive/simple_item_factory.cpp 2013-02-21 18:17:25 +
@@ -580,6 +580,114 @@
}
+bool BasicItemFactory::createDateTimeStamp(store::Item_t result, const xs_dateTime* value)
+{
+ if( value-hasTimezone() )
+ {
+result = new DateTimeItem(store::XS_DATETIME, value);
+return true;
+ }
+ else
+ {
+result = NULL;
+return false;
+ }
+}
+
+
+bool BasicItemFactory::createDateTimeStamp(
+ store::Item_t result,
+ const xs_date* date,
+ const xs_time* time)
+{
+ std::auto_ptrDateTimeItem dtin(new DateTimeItem(store::XS_DATETIME_STAMP));
+ int err = DateTime::createDateTime(date, time, dtin-theValue);
+ if (err == 0 time-hasTimezone())
+ {
+result = dtin.get();
+dtin.release();
+return true;
+ }
+ else
+ {
+result = NULL;
+return false;
+ }
+}
+
+
+bool BasicItemFactory::createDateTimeStamp(
+ store::Item_t result,
+ short year ,
+ short month,
+ short day,
+ short hour,
+
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Review: Needs Information What about changing fn:current-dateTime() and our other nondeterministic dateTime functions? -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
What about changing fn:current-dateTime() and our other nondeterministic dateTime functions? Sorin brought it up, we're trying to figure out a way to have it enabled. It's on my list, looking at it right now. -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
