This proposals has been replaced by the following:
https://code.launchpad.net/~zorba-coders/zorba/bug1058231b/+merge/139556
Therefore I'm marking this one as Rejected to clean it off the list.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1058231/+merge/129531
Your team Zorba Coders is
The proposal to merge lp:~zorba-coders/zorba/bug1058231 into lp:zorba has been
updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1058231/+merge/129531
--
https://code.launchpad.net/~zorba-coders/zorba/bug1058231/+merge/129531
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug1058231/+merge/129531
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
- bad include +#include ../include/zorba/config.h
- it seems like entire files have been removed and added (potential newline
problem)?
- set_env_var seems to be a bad name for the function. What the function really
does is get_env_var, right?
--
The removed/added problem is because Rodolfo initially deleted them, but then
put them back based on my earlier comment. Unfortunately I don't know of a
way to fix this.
The way I usually solve this (if the history of the branch is not terribly
relevant) is to create a patch from the branch,
sorry for the delay, is now on config.h
--
https://code.launchpad.net/~zorba-coders/zorba/bug1058231/+merge/129531
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The changes all look good to me now; thanks.
However, I just noticed something else that might be an issue for 28msec.
Matthias, this code changes the magic Windows behaviour of finding modules
based on the install location of Zorba. It used to be that it would find the
location of zorba.exe.
The changes all look good to me now; thanks.
However, I just noticed something else that might be an issue for 28msec.
Matthias, this code changes the magic Windows behaviour of finding modules
based on the install location of Zorba. It used to be that it would find the
location of
PathUtil has been restored and fixed.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1058231/+merge/129531
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
You can't remove path_util.cpp - it also handles the --lib-path and --uri-path
command-line options, not just the environment variables. So you can get rid of
getPathFromEnvironment(), and the parts of setPathsOnContext() which reference
lEnvStr, but the rest has to stay,
Review: Needs Fixing
I think you need to remove the corresponding getenv code from
bin/path_util.cpp, or else it'll get executed twice when running zorba.exe.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1058231/+merge/129531
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Review: Needs Information
I'm assuming that the main fix here works. However I'm a bit confused why it
matters whether we find the path to zorba.exe or zorba_simplestore.dll, because
as far as I know they should always be in the same directory. So to satisfy my
curiosity, why is this change
1-
Because Zorba Processor is not zorba.exe, is zorba_simplestore.dll, so, when
you make a call from Java, the actual process is c:\...\java.exe calling
zorba_simplestore among other dll's, so the paths come from java.exe.
2-
Same principle will apply here, when Zorba is called from other
Ah, OK, thanks for the explanation.
As for whether this should be done cross-platform:
1. There is no way that we have discovered to determine the path to
zorba_simplestore (or zorba itself) on Linux or Mac, so there is no equivalent
problem to be solved there (yet?).
2. It would be best if
Rodolfo Ochoa has proposed merging lp:~zorba-coders/zorba/bug1058231 into
lp:zorba.
Commit message:
The problem was in the path from the process, instead of using the path of
zorba_simplestore.dll Zorba gather the path of the main EXE.
This problem is not only from WinXP.
Requested reviews:
The proposal to merge lp:~zorba-coders/zorba/bug1058231 into lp:zorba has been
updated.
Commit Message changed to:
The problem was in the path from the process, instead of using the path of
zorba_simplestore.dll Zorba gather the path of the main EXE.
This problem is not only from WinXP
16 matches
Mail list logo
