[Zorba-coders] [Merge] lp:~davidagraf/zorba/data-formatting-module-bug-989490 into lp:zorba/data-formatting-module

2012-11-07 Thread David Graf
The proposal to merge lp:~davidagraf/zorba/data-formatting-module-bug-989490 into lp:zorba/data-formatting-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~davidagraf/zorba/data-formatting-module-bug-989490/+merge/110273 -- https:/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/image-module-dont-pass-svg-as-binary into lp:zorba/image-module

2012-11-07 Thread David Graf
Matthias, is it ok for you now? -- https://code.launchpad.net/~zorba-coders/zorba/image-module-dont-pass-svg-as-binary/+merge/131829 Your team Zorba Coders is subscribed to branch lp:zorba/image-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba_FOTS_driver into lp:zorba

2012-11-07 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/zorba_FOTS_driver/+merge/132980 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

[Zorba-coders] [Merge] lp:~davidagraf/zorba/data-formatting-module-bug-989490 into lp:zorba/data-formatting-module

2012-11-07 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/data-formatting-module-bug-989490-2012-11-07T11-12-30.016Z/log.html -- https://code.launchpad.net/~davidagraf/zorba/data-formatting-module-bug-989490/+merge/110273 Your team Zorba Coders is subscribe

[Zorba-coders] [Merge] lp:~davidagraf/zorba/data-formatting-module-bug-989490 into lp:zorba/data-formatting-module

2012-11-07 Thread Zorba Build Bot
Validation queue job data-formatting-module-bug-989490-2012-11-07T11-12-30.016Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~davidagraf/zorba/data-formatting-module-bug-989490/+merge/110273 Your team Zorba Coders is subscribed to branch lp:zorba/data-for

[Zorba-coders] [Merge] lp:~davidagraf/zorba/data-formatting-module-bug-989490 into lp:zorba/data-formatting-module

2012-11-07 Thread noreply
The proposal to merge lp:~davidagraf/zorba/data-formatting-module-bug-989490 into lp:zorba/data-formatting-module has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~davidagraf/zorba/data-formatting-module-bug-989490/+merge/110273 -- https://code.

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/schema-tools-module-module-bug-989490 into lp:zorba/schema-tools-module

2012-11-07 Thread David Graf
Chris, the other merge proposal went through (data-formatting-module). Can you approve this one too? -- https://code.launchpad.net/~davidagraf/zorba/schema-tools-module-module-bug-989490/+merge/110271 Your team Zorba Coders is subscribed to branch lp:zorba/schema-tools-module. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/schema-tools-module-module-bug-989490 into lp:zorba/schema-tools-module

2012-11-07 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~davidagraf/zorba/schema-tools-module-module-bug-989490/+merge/110271 Your team Zorba Coders is subscribed to branch lp:zorba/schema-tools-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net U

[Zorba-coders] [Merge] lp:~davidagraf/zorba/schema-tools-module-module-bug-989490 into lp:zorba/schema-tools-module

2012-11-07 Thread Chris Hillery
The proposal to merge lp:~davidagraf/zorba/schema-tools-module-module-bug-989490 into lp:zorba/schema-tools-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~davidagraf/zorba/schema-tools-module-module-bug-989490/+merge/110271 -- h

[Zorba-coders] [Merge] lp:~davidagraf/zorba/schema-tools-module-module-bug-989490 into lp:zorba/schema-tools-module

2012-11-07 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/schema-tools-module-module-bug-989490-2012-11-07T12-03-39.463Z/log.html -- https://code.launchpad.net/~davidagraf/zorba/schema-tools-module-module-bug-989490/+merge/110271 Your team Zorba Coders is s

[Zorba-coders] [Merge] lp:~davidagraf/zorba/schema-tools-module-module-bug-989490 into lp:zorba/schema-tools-module

2012-11-07 Thread Zorba Build Bot
Validation queue job schema-tools-module-module-bug-989490-2012-11-07T12-03-39.463Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~davidagraf/zorba/schema-tools-module-module-bug-989490/+merge/110271 Your team Zorba Coders is subscribed to branch lp:zorba

[Zorba-coders] [Merge] lp:~davidagraf/zorba/schema-tools-module-module-bug-989490 into lp:zorba/schema-tools-module

2012-11-07 Thread noreply
The proposal to merge lp:~davidagraf/zorba/schema-tools-module-module-bug-989490 into lp:zorba/schema-tools-module has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~davidagraf/zorba/schema-tools-module-module-bug-989490/+merge/110271 -- https:/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/image-module-dont-pass-svg-as-binary into lp:zorba/image-module

2012-11-07 Thread Matthias Brantner
Review: Needs Fixing - getImageFromString: const String aString, should be const String& aString, - basic:convert-svg-impl should use basic:convert-svg-string - we might have to make sure the new module is used in Zorba (edit ExternalModules.conf) -- https://code.launchpad.net/~zorba-coders/zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba_FOTS_driver into lp:zorba

2012-11-07 Thread Matthias Brantner
Review: Needs Fixing The implementation looks very clean. I poked around a bit and ran several random test sets. The feeling I got is that it's not quite ready yet for merging. I would like to avoid waisting time when more people start using it and all run into the same issues. Before we conti

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba

2012-11-07 Thread Till Westmann
Review: Needs Fixing When running foaf-json-xml-index-point-maintenance.xq I run into a memory problem: ==13041== Invalid read of size 8 ==13041==at 0x5ED4C32: zorba::simplestore::CollectionTreeInfo::getCollection() const (collection_tree_info.h:54) ==13041==by 0x5EC3C45: zorba::simpl

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba

2012-11-07 Thread Markos Zaharioudakis
1. I don't see the zorba cmd doing anything with the --disable-http-resolution option, if that option is actually specified in the command line. 2. If a user uses the option inside an xquery module, it will have no effect because options are processed after the imports. Such a user will then be

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba

2012-11-07 Thread Markos Zaharioudakis
Review: Needs Fixing -- https://code.launchpad.net/~zorba-coders/zorba/bug-867363-disable-http/+merge/133032 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba

2012-11-07 Thread Chris Hillery
> 1. I don't see the zorba cmd doing anything with the --disable-http-resolution > option, if that option is actually specified in the command line. See the second diff in zorbacmdproperties_base.h. It just explicitly sets the disable-http-resolution option on the static context by using the same

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba

2012-11-07 Thread Markos Zaharioudakis
> > 1. I don't see the zorba cmd doing anything with the --disable-http- > resolution > > option, if that option is actually specified in the command line. > > See the second diff in zorbacmdproperties_base.h. It just explicitly sets the > disable-http-resolution option on the static context by us

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba

2012-11-07 Thread Chris Hillery
> Ok, I got it. But the actual update of the static context is not done in > zorbacmdproperties_base.h; it is done in zorbacmd.cpp:179. Yes, by iterating through the options from zorbacmdproperties.. :) I did test the command-line option, it definitely does the trick. I will add a test case in b

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba_FOTS_driver into lp:zorba

2012-11-07 Thread Chris Hillery
> - How do I know whether my test run actually ran any tests? Sometimes I had a > typo in the prefix and it didn't run anything but it's hard to see. Do you have fn:trace() disabled? When I run a test set I see trace output for each test as it is run. This seemed like the right approach to me. A