[Zorba-coders] [Merge] lp:~markos-za/zorba/markos-bugs into lp:zorba

2011-09-22 Thread Markos Zaharioudakis
The proposal to merge lp:~markos-za/zorba/markos-bugs into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/76591 -- https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/76591 Your

[Zorba-coders] [Merge] lp:~markos-za/zorba/markos-bugs into lp:zorba

2011-09-22 Thread Markos Zaharioudakis
The proposal to merge lp:~markos-za/zorba/markos-bugs into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/76625 -- https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/76625 Your

[Zorba-coders] [Merge] lp:~markos-za/zorba/markos-bugs into lp:zorba

2011-09-23 Thread Markos Zaharioudakis
The proposal to merge lp:~markos-za/zorba/markos-bugs into lp:zorba has been updated. Commit Message changed to: fixed some problems in XQTS.xml For more details, see: https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/76641 --

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs into lp:zorba

2011-09-27 Thread Markos Zaharioudakis
The proposal to merge lp:~fcavalieri/zorba/bugs into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/77063 -- https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/77063 Your team Zorba Coders is

Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs into lp:zorba

2011-09-28 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/77287 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More

[Zorba-coders] [Bug 855314] Re: Assertion failed in typemanager with for and el constuctor

2011-09-28 Thread Markos Zaharioudakis
** Changed in: zorba Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Zorba Coders, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/855314 Title: Assertion failed in typemanager with for and el constuctor

[Zorba-coders] [Merge] lp:~matthias-brantner/zorba/external_func_param into lp:zorba

2011-09-29 Thread Markos Zaharioudakis
The proposal to merge lp:~matthias-brantner/zorba/external_func_param into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~matthias-brantner/zorba/external_func_param/+merge/77410 --

Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/external_func_param into lp:zorba

2011-09-29 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~matthias-brantner/zorba/external_func_param/+merge/77255 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/external_func_param into lp:zorba

2011-09-29 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~matthias-brantner/zorba/external_func_param/+merge/77410 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~markos-za/zorba/markos-bugs into lp:zorba

2011-09-29 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~markos-za/zorba/markos-bugs into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/77510 -- https://code.launchpad.net/~markos-za/zorba/markos-bugs

Re: [Zorba-coders] [Merge] lp:~markos-za/zorba/markos-bugs into lp:zorba

2011-09-29 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/77510 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~markos-za/zorba/markos-bugs into lp:zorba

2011-09-29 Thread Markos Zaharioudakis
The proposal to merge lp:~markos-za/zorba/markos-bugs into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/77510 -- https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/77510 Your

Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/external_func_param into lp:zorba

2011-09-29 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~matthias-brantner/zorba/external_func_param/+merge/77567 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~matthias-brantner/zorba/external_func_param into lp:zorba

2011-09-29 Thread Markos Zaharioudakis
The proposal to merge lp:~matthias-brantner/zorba/external_func_param into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~matthias-brantner/zorba/external_func_param/+merge/77567 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-01 Thread Markos Zaharioudakis
In simple_store.cpp:1351, we should be creating a URI item, not a string item, right? -- https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/77693 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/bug-863730 into lp:zorba

2011-10-03 Thread Markos Zaharioudakis
Matthias, I did not look at those tests to see how important they are. But, if they do test something important, rather than changing the expected result, I think you should modify the tests to use an ordered collection, and add one or two new tests for the error condition. --

Re: [Zorba-coders] [Merge] lp:~markos-za/zorba/markos-bugs into lp:zorba

2011-10-03 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/77874 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~markos-za/zorba/markos-bugs into lp:zorba

2011-10-03 Thread Markos Zaharioudakis
The proposal to merge lp:~markos-za/zorba/markos-bugs into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/77874 -- https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/77874 Your

[Zorba-coders] [Merge] lp:~markos-za/zorba/markos-bugs into lp:zorba

2011-10-03 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~markos-za/zorba/markos-bugs into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/77874 -- https://code.launchpad.net/~markos-za/zorba/markos-bugs

Re: [Zorba-coders] [Merge] lp:~markos-za/zorba/indexes into lp:zorba

2011-10-04 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~markos-za/zorba/indexes/+merge/78060 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Markos Zaharioudakis
4. Should we say something about text nodes, eg, that their identifier is not really immutable and it can be used to dereference the node only during the same snapshot in which the identifier was retrieved? This refers to the other module, the one with the structural uris.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Markos Zaharioudakis
What is the CopyMode's theCopyReference member for? Isn't it always false? Yes in the current module it is. Should I move it in the branch which uses it/by itself? YES! I made the same suggestion in one of my other comments. Identifiers are useful by themselves, i.e., independently from

[Zorba-coders] [Merge] lp:~markos-za/zorba/markos-bugs into lp:zorba

2011-10-10 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~markos-za/zorba/markos-bugs into lp:zorba. Requested reviews: Matthias Brantner (matthias-brantner) For more details, see: https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/78812 -- https://code.launchpad.net/~markos-za/zorba/markos

[Zorba-coders] [Bug 867262] Re: Ext func arg item seq can not be consumed 2 times

2011-10-10 Thread Markos Zaharioudakis
Gabriel, would it be ok with your use case if instead of calling getIterator() a second time, you reused the same iterator? Basically, the code would look something like this: Item item; Iterator_t iter = args[0] -getIterator( ); iter-open(); iter-next(item); iter-close(); // iter = args[0]

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-10 Thread Markos Zaharioudakis
Federico I made some changes to the branch, the most important of which is that I removed from SimpleStore the methods related to copying of identifiers. I guess you will have to put this code back in the branch where it is actually used. --

[Zorba-coders] [Merge] lp:~markos-za/zorba/bugs2 into lp:zorba

2011-10-10 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~markos-za/zorba/bugs2 into lp:zorba. Requested reviews: Federico Cavalieri (fcavalieri) For more details, see: https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834 -- https://code.launchpad.net/~markos-za/zorba/bugs2/+merge/78834 Your

[Zorba-coders] [Merge] lp:~markos-za/zorba/markos-bugs into lp:zorba

2011-10-10 Thread Markos Zaharioudakis
The proposal to merge lp:~markos-za/zorba/markos-bugs into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/78812 -- https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/78812 Your

[Zorba-coders] [Merge] lp:~markos-za/zorba/markos-bugs into lp:zorba

2011-10-10 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~markos-za/zorba/markos-bugs into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/78881 -- https://code.launchpad.net/~markos-za/zorba/markos-bugs

Re: [Zorba-coders] [Merge] lp:~markos-za/zorba/markos-bugs into lp:zorba

2011-10-10 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/78881 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~markos-za/zorba/markos-bugs into lp:zorba

2011-10-10 Thread Markos Zaharioudakis
The proposal to merge lp:~markos-za/zorba/markos-bugs into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/78881 -- https://code.launchpad.net/~markos-za/zorba/markos-bugs/+merge/78881 Your

[Zorba-coders] [Bug 867262] Re: Ext func arg item seq can not be consumed 2 times

2011-10-11 Thread Markos Zaharioudakis
** Changed in: zorba Status: New = Fix Released -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/867262 Title: Ext func arg item seq can not be consumed 2 times Status in Zorba - The

Re: [Zorba-coders] [Merge] lp:~markos-za/zorba/bugs2 into lp:zorba

2011-10-11 Thread Markos Zaharioudakis
Hi Markos, i think that the flag haveListType is not reset correctly if the element passes from haveTypedValue haveTypedTypedValue haveListType to haveTypedValue haveTypedTypedValue !haveListType I would add: else textChild-resetHaveListValue(); near line 499 of

Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs into lp:zorba

2011-10-12 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/79070 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More

[Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs into lp:zorba

2011-10-12 Thread Markos Zaharioudakis
The proposal to merge lp:~fcavalieri/zorba/bugs into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/79070 -- https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/79070 Your team Zorba Coders is

Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs2 into lp:zorba

2011-10-12 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~fcavalieri/zorba/bugs2/+merge/78401 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders

Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/setsatundo into lp:zorba

2011-10-12 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~fcavalieri/zorba/setsatundo/+merge/79093 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba

2011-10-13 Thread Markos Zaharioudakis
function name too long? node-structural-information Any suggestions? node-information node-position node-uri structural-information I like node-information as name for both - the module and the function. That's at least consistent with the node-reference module and

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/updrevalidate into lp:zorba. Requested reviews: Federico Cavalieri (fcavalieri) Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 -- https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Markos Zaharioudakis
Federico, I forgot to submit some cosmetic changes to this branch before pushing the approve button. So, now I have created this new merge proposal. Can you please review? Thanks!. -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed

[Zorba-coders] [Merge] lp:~markos-za/zorba/indexes into lp:zorba

2011-10-13 Thread Markos Zaharioudakis
The proposal to merge lp:~markos-za/zorba/indexes into lp:zorba has been updated. Commit Message changed to: 1. Big reorg of the code for general indexes: 1.1 Unified code for creating hash- and tree-based index 1.2 Unified code among different kinds of probe functions 1.3 Improved performance

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Markos Zaharioudakis
Why variable numUpdates in PULImpl::mergeUpdateList is declared, assigned but never read? Good question :) The easy answer is to just remove it. But I think it can actually be used to replace the myList.size() in the 2 for loops at lines 1289 and 1308. Even though new entries can be added in

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-14 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/updrevalidate into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 --

Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba

2011-10-14 Thread Markos Zaharioudakis
Renamed the module and function to node-position. How should I replace structural information in the functions comments? node position uri? I rewrote somewhat the introductory comment in node-position.xq. Here is the new version: (:~ : This module provides a function (np:node-position)

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-14 Thread Markos Zaharioudakis
Federico, I don't think it is necessary to put the position uris into the uri pool because they are not likely to be shared by multiple data items so you won't really be saving much space (you may be actually end-up wasting space because the uri pool storage has some overhead by itself). Do you

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-14 Thread Markos Zaharioudakis
Should StructuralAnyUriItem::isDescendant() check that the other node is not an attribute? -- https://code.launchpad.net/~zorba-coders/zorba/structuralrelationships2/+merge/78395 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-14 Thread Markos Zaharioudakis
Should StructuralAnyUriItem::isDescendant() check that the other node is not an attribute? Yes, you are right! Descendant doesn't include attributes. May I add a in-subtree-of function with the same semantics as the current descendant? Thanks Federico It's ok with me, if it is

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-17 Thread Markos Zaharioudakis
Hi Markos, i noticed that the parse uri function now uses strtoul without checking errno with the following effects: A missing component is considered 0: np:in-same-tree-of(xs:anyURI(zorba:..1.50),xs:anyURI(zorba:0.0.1.50)) -true Out of ulong value-space == ULONG_MAX

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos1 into lp:zorba

2011-10-18 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos1 into lp:zorba. Requested reviews: Matthias Brantner (matthias-brantner) Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos1/+merge/79723 optimization: store

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos1 into lp:zorba

2011-10-18 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/markos1 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos1/+merge/79723 -- https://code.launchpad.net/~zorba-coders/zorba/markos1/+merge/79723 Your team

Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/bug-fixing into lp:zorba

2011-10-18 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~matthias-brantner/zorba/bug-fixing/+merge/79732 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos1 into lp:zorba

2011-10-18 Thread Markos Zaharioudakis
Matthias, this is not really ready for checkin yet. We need to find a way to address the xray regression caused by this memory optimization. -- https://code.launchpad.net/~zorba-coders/zorba/markos1/+merge/79746 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/bug-fixing into lp:zorba

2011-10-18 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~matthias-brantner/zorba/bug-fixing/+merge/79743 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~matthias-brantner/zorba/bug-fixing into lp:zorba

2011-10-18 Thread Markos Zaharioudakis
The proposal to merge lp:~matthias-brantner/zorba/bug-fixing into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~matthias-brantner/zorba/bug-fixing/+merge/79743 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-19 Thread Markos Zaharioudakis
Connection dropped... Do you know why document nodes have a component less than any other kind of node when they are the root of their tree? I finally found out what you meant (the code is in the OrdPathNode ctor, not the OrdPath ctor). I think the reason why element node as root has an

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-19 Thread Markos Zaharioudakis
Federico, I think the documentation in node-position.xq needs some more work. I can do this, but first we must agree on what is exactly the functionality and the assumptions about node positions that you rely on. For example, in the documentation of the np:node-position() function, you write:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug_872732 into lp:zorba

2011-10-19 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug_872732/+merge/79272 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~juan457/zorba/xqxq-api-changes into lp:zorba

2011-10-19 Thread Markos Zaharioudakis
Juan, the getExternalVariables method should be part of the static context, not the dynamic context. Probably the easiest way to implement this is to add an externalOnly param to the static_context::getVariables method and then add a getExternalVariables method in StaticContextImpl, which will

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/collection-counting into lp:zorba

2011-10-20 Thread Markos Zaharioudakis
Carlos, let's try to finis this today and commit to the main trunk. So, please add a test for w3c collections, and also update the ChangeLog file with a one-line description of the change. -- https://code.launchpad.net/~zorba-coders/zorba/collection-counting/+merge/79765 Your team Zorba Coders

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/collection-counting into lp:zorba

2011-10-20 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/collection-counting/+merge/79765 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/collection-counting into lp:zorba

2011-10-20 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/collection-counting into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/collection-counting/+merge/79765 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/collection-counting into lp:zorba

2011-10-20 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/collection-counting into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/collection-counting/+merge/79765 --

Re: [Zorba-coders] [Merge] lp:~juan457/zorba/xqxq-api-changes into lp:zorba

2011-10-20 Thread Markos Zaharioudakis
Ok, it looks better now, but we are not done yet First, the comment in include/zorba/static_context.h for the getExternalVariables() method is wrong. The method returns the qnames of all the external variables that are in-scope within that static context. It's not about whether the

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/collection-counting into lp:zorba

2011-10-20 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/collection-counting into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/collection-counting/+merge/79765 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/collection-counting into lp:zorba

2011-10-20 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/collection-counting/+merge/79765 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/collection-counting into lp:zorba

2011-10-20 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/collection-counting/+merge/79765 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/collection-counting into lp:zorba

2011-10-20 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/collection-counting/+merge/79765 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/collection-counting into lp:zorba

2011-10-20 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/collection-counting into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/collection-counting/+merge/79765 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/collection-counting into lp:zorba

2011-10-20 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/collection-counting into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/collection-counting/+merge/79765 --

Re: [Zorba-coders] [Merge] lp:~juan457/zorba/xqxq-api-changes into lp:zorba

2011-10-20 Thread Markos Zaharioudakis
Second, to get the external variables from all the modules that participate in a query, we also need a getExternalVariables() at the XQueryImpl level. This method will go through all the static context objs in theCompilerCB-theSctxMap and compute the union of the external variables

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos2 into lp:zorba

2011-10-23 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/markos2/+merge/80129 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos2 into lp:zorba

2011-10-23 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/markos2 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos2/+merge/80129 -- https://code.launchpad.net/~zorba-coders/zorba/markos2/+merge/80129 Your team

Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/bugs into lp:zorba

2011-10-26 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~fcavalieri/zorba/bugs/+merge/80487 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-10-29 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/structuralrelationships2/+merge/78395 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-skinny into lp:zorba

2011-10-30 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-skinny into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-skinny/+merge/80756 moved base uri and doc uri from the XmlTree

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-skinny into lp:zorba

2011-10-30 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/markos-skinny/+merge/80756 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-skinny into lp:zorba

2011-10-30 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/markos-skinny into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-skinny/+merge/80756 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-skinny into lp:zorba

2011-10-31 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/markos-skinny into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-skinny/+merge/80756 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-annotations into lp:zorba

2011-11-01 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-annotations into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-annotations/+merge/80899 simplified and optimized

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-annotations into lp:zorba

2011-11-01 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/markos-annotations/+merge/80899 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-annotations into lp:zorba

2011-11-01 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/markos-annotations into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-annotations/+merge/80899 --

Re: [Zorba-coders] [Merge] lp:~juan457/zorba/xqxq-api-changes into lp:zorba

2011-11-01 Thread Markos Zaharioudakis
Juan, can you please make zorba-coders be the owner of this branch. I want to make some changes to it, but I cannot because it currently belongs to you only. -- https://code.launchpad.net/~juan457/zorba/xqxq-api-changes/+merge/79589 Your team Zorba Coders is subscribed to branch lp:zorba. --

Re: [Zorba-coders] [Merge] lp:~markos-za/zorba/indexes into lp:zorba

2011-11-01 Thread Markos Zaharioudakis
some parameters of the probe-index-range-general#7 function are not documented. Also, should this function be variadic? I have added the missing params. No, the function is not variadic because it applies to general indexes only, whicg have only one key column. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-annotations into lp:zorba

2011-11-01 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/markos-annotations into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-annotations/+merge/80899 --

Re: [Zorba-coders] [Merge] lp:~juan457/zorba/xqxq-api-changes into lp:zorba

2011-11-01 Thread Markos Zaharioudakis
The implementation of getExternalVariables in the xqueryimpl level is done. Juan, I fixed the implementation of the XQuery::getExternalVariables() method. The main problem there was that you were comparing QName items using their string value. This is not correct because the string value of a

Re: [Zorba-coders] [Merge] lp:~markos-za/zorba/indexes into lp:zorba

2011-11-01 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~markos-za/zorba/indexes/+merge/79334 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-11-02 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/structuralrelationships2/+merge/81053 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba

2011-11-02 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/structuralrelationships2 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/structuralrelationships2/+merge/81053 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2011-11-06 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/81432 trying to fix Windows compilation problem

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2011-11-06 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/81432 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2011-11-06 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/81432 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2011-11-06 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/81434 fixed a wrong assertion in annotations.cpp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2011-11-06 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/81434 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2011-11-06 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/81434 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-api-changes into lp:zorba

2011-11-08 Thread Markos Zaharioudakis
Found a function that does exactly the same changing it. I implemented the isBoundExternalVariable adding a new function in context/dynamic_context called is_set_variable which returns true if it is set or false if it doesn't I could have use the get_variable but I would have to catch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2011-11-10 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/81857 optimizer optimization:avoid double traversal

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2011-11-10 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/81857 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-api-changes into lp:zorba

2011-11-11 Thread Markos Zaharioudakis
Added the error throw and also changed getExternalVariables to use iterators instead of a vector Juan, XPST0008 is not a bad choice for the error code, but in this case, the error does not come from an xquery program but from the zorba c++ api. So, you must create a new error code. To do this

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/substring-intopt into lp:zorba

2011-11-11 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/substring-intopt into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/substring-intopt/+merge/81949 Optimization of the fn:substring function

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2011-11-11 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/81857 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

  1   2   3   4   5   6   7   8   9   10   >