- The function check_xquery_feature_options is too long. Could this be
simplified and/or split into multiple functions?
DONE
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
- It feels like most of the implementation should go into the translator and
not into the static context.
DONE
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
- The style of the error messages is not consistent with the other error
messages. They should be changed as follows:
XQST0120 $1: feature not supported
XQST0128 $1: unable to disable a supported feature
XQST0126 impossible to activate all extension features
DONE
--
I think I addressed all comments.
There are three expected failures left:
EXPECTED_FOTS_FAILURE (prod-RequireProhibitFeature
require-higher-order-function-5-s 0)
EXPECTED_FOTS_FAILURE (prod-RequireProhibitFeature
require-higher-order-function-10-s 0)
- This is the for $f in () return $f(1, ?)
I opened the bug for the first two expected failures here: bug 1171860.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
EXPECTED_FOTS_FAILURE (prod-RequireProhibitFeature
require-all-optional-features-5-s 0)
- I removed it because the test suite got updated in the trunk.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~zorba-coders/zorba/bug-1123165 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge
The proposal to merge lp:~zorba-coders/zorba/bug-1123165 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge
Review: Disapprove
Disapproving to allow running tests without merging.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The proposal to merge lp:~zorba-coders/zorba/bug-1123165 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-1123165-2013-04-23T13-54-43.634Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job bug-1123165-2013-04-23T13-54-43.634Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 2
Approve, 1 Disapprove, 1 Needs Fixing.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is
- The fix for dynamic_function_invocation seems to be orthogonal. Why is this
fixed in this merge proposal? I couldn't find a test to cover this behavior.
It does fix some of the W3C tests:
for $f in () return $f(1, ?)
Raised an error in zorba because it was considered an object
Review: Approve
awesome
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
This is one of the cases that we will have to live with. It's a conflict between
JSONiq and HOF. We were trying to push the W3C to make the dynamic function
invocation
a map (i.e. $f could be () or a sequence of function items). However, the w3c
didn't
want to go this way.
- In this case, $f is
We do not have to consider $f an object lookup in this case, right? I have
the more general feeling that there might be something wrong in type
inference regarding for loops on empty sequences.
Since there is a partial application ?, it definitely cannot be an object
lookup.
--
The proposal to merge lp:~zorba-coders/zorba/bug-1123165 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-1123165-2013-04-23T15-14-42.012Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job bug-1123165-2013-04-23T15-14-42.012Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug-1123165 into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
- The fix for dynamic_function_invocation seems to be orthogonal. Why is this
fixed in this merge proposal? I couldn't find a test to cover this behavior.
It does fix some of the W3C tests:
for $f in () return $f(1, ?)
Raised an error in zorba because it was considered an object lookup.
Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/bug-1123165 into
lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
Related bugs:
Bug #1123165 in Zorba: failures in require-feature and prohibit-feature (at
least 27)
https://bugs.launchpad.net/zorba/+bug/1123165
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/bug-1123165 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge
The proposal to merge lp:~zorba-coders/zorba/bug-1123165 into lp:zorba has been
updated.
Commit Message changed to:
Fixing bug 1123165 (prohibit/require feature tests).
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
--
https
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-1123165-2013-04-19T14-11-47.953Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The attempt to merge lp:~zorba-coders/zorba/bug-1123165 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug-1123165-2013-04-19T14-11-47.953Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/bug-1123165 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge
Review: Needs Fixing
- The fix for dynamic_function_invocation seems to be orthogonal. Why is this
fixed in this merge proposal? I couldn't find a test to cover this behavior.
- The function check_xquery_feature_options is too long. Could this be
simplified and/or split into multiple
Ghislain, could you also please remove the fix that you submitted for scanner.l
problem? Your proposal works, but on linux the GCC gives off a warning for that
code. I have a proposal that fixes the issue in another branch, which Matthias
will approve and merge soon.
--
I too agree that it should be moved to the translator. That's where all the
similar code currently is. Other than this and the scanner issue, it looks good
for me.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
34 matches
Mail list logo
