On 11/12/2018 20:00, Sean Mullan wrote:
These exceptions are generated from a very low level part of the
native JDK Windows or Unix FileSystem implementations. That is a
concern. The previous usages of this property were more focused and
confined to smaller parts of the code resulting in fewer code paths to
analyze.
I think we need to take a step back. I think we need to reconsider
whether the jdk.includeInExceptions security property is appropriate
for this type of enhancement.
Therefore, I oppose this change as-is. I'm happy to participate in a
more involved discussion where we start with use cases and motivation
before jumping to solutions.
I also dislike this patch and you are probably right that
jdk.includeInExceptions needs to be re-examined or pulled out
completely. In addition to the surprise leakage issue, this patch is
inconsistent as it hanges the exception for only a subset of the file
system operations.
-Alan