On Tue, 23 Mar 2021 17:16:04 GMT, Greg Rubin 
<github.com+829871+salusasecon...@openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Changed AlgorithmParameters impls to register under AES/KW/NoPadding and
>>   AES/KWP/NoPadding
>
> test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/NISTWrapKAT.java line 105:
> 
>> 103: 
>> 104:     @DataProvider
>> 105:     public Object[][] testData() {
> 
> Can we please add test cases for `AES/KWP/NoPadding` where the input is an 
> even multiple of 8? We've [seen bugs in this case 
> before](https://github.com/pyca/cryptography/issues/4156).

Sure, there are some more from the NIST zip.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2404

Reply via email to