On Tue, 23 Mar 2021 19:14:16 GMT, Greg Rubin
<github.com+829871+salusasecon...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changed AlgorithmParameters impls to register under AES/KW/NoPadding and
>> AES/KWP/NoPadding
>
> test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestGeneral.java line 50:
>
>> 48:
>> 49: System.out.println("input len: " + inLen);
>> 50: c.init(Cipher.ENCRYPT_MODE, KEY, new IvParameterSpec(in, 0,
>> ivLen));
>
> Do we have tests for no IV (and thus the default)?
> Do we have tests that the null (default) IV matches the results from an
> explicitly provided default ID?
In NISTWrapKAT.java, all of its test vectors do not use custom IV. So, the
default IV scenario for KW and KWP are covered there. I can add another
init(...) call which sets the IV based on the current IV to that test.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2404
