On Tue, 25 Mar 2025 22:27:36 GMT, Anthony Scarpino <ascarp...@openjdk.org>
wrote:
>> test/jdk/sun/security/util/AlgorithmConstraints/DisabledAlgorithmPermits.java
>> line 8:
>>
>>> 6: * under the terms of the GNU General Public License version 2 only, as
>>> 7: * published by the Free Software Foundation. Oracle designates this
>>> 8: * particular file as subject to the "Classpath" exception as provided
>>
>> The copyright notice for a test does not need the "Classpath" exception.
>
> All these years I never noticed the test and src copyrights were different.
IANAL but the "Classpath" seems to allow you to include (or reference or link
or whatever) this (or its compiled form or whatever) in your own non-GPL app.
This is necessary for JDK since it is the runtime for an app. On the other
hand, there is no need to make this relaxation for tests. Again, IANAL.
>> test/jdk/sun/security/util/AlgorithmConstraints/DisabledAlgorithmPermits.java
>> line 173:
>>
>>> 171: record TestCase(int testType, String testAlgo, boolean expected) {
>>> 172: TestCase(String testAlgo, boolean expected) {
>>> 173: this( 0, testAlgo, expected);
>>
>> Remove the space before '0'.
>
> ah.. intellij hid that from me
You let it show the arg name?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23647#discussion_r2013028124
PR Review Comment: https://git.openjdk.org/jdk/pull/23647#discussion_r2013029256
