On Mon, 24 Mar 2025 17:24:01 GMT, Artur Barashev <abaras...@openjdk.org> wrote:

>> Currently when a signature scheme constraint is specified with 
>> "jdk.tls.disabledAlgorithms" property we don't differentiate between 
>> signatures used to sign a TLS handshake exchange and the signatures used in 
>> TLS certificates:
>> https://datatracker.ietf.org/doc/html/rfc8446#section-4.2.3
>
> Artur Barashev has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix java.security syntax. Remove whitespace.

test/jdk/sun/security/ssl/SignatureScheme/AbstractCheckSignatureSchemes.java 
line 127:

> 125:      *                      a well-formed TLS message.
> 126:      */
> 127:     protected ByteBuffer extractHandshakeMsg(ByteBuffer tlsRecord,

This seems like quite a useful method! How about adding it to the superclass 
`SSLEngineTemplate` so that we might use it for other tests in the future.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23681#discussion_r2017417135

Reply via email to