On Thu, 27 Mar 2025 19:33:46 GMT, Artur Barashev <abaras...@openjdk.org> wrote:

>> test/jdk/sun/security/ssl/SignatureScheme/AbstractCheckSignatureSchemes.java 
>> line 77:
>> 
>>> 75:     }
>>> 76: 
>>> 77:     protected String getProtocol() {
>> 
>> I'd be more inclined to make this abstract and force subclasses to override 
>> it.
>
> Will do. I also though about it but since the original 
> `SigSchemePropOrdering` test had "TLSv1.2" I kept it as default.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23681#discussion_r2017736970

Reply via email to