On Thu, 27 Mar 2025 18:33:56 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix java.security syntax. Remove whitespace. > > test/jdk/sun/security/ssl/SignatureScheme/AbstractCheckSignatureSchemes.java > line 127: > >> 125: * a well-formed TLS message. >> 126: */ >> 127: protected ByteBuffer extractHandshakeMsg(ByteBuffer tlsRecord, > > This seems like quite a useful method! How about adding it to the superclass > `SSLEngineTemplate` so that we might use it for other tests in the future. Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23681#discussion_r2017733958