On Thu, 20 Nov 2025 21:31:31 GMT, Sandhya Viswanathan
<[email protected]> wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - whitespace
>> - address first comments
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 1283:
>
>> 1281: // r1 = r1 & quotient; // copy 0 or keep as is, using EqMsk as
>> filter
>> 1282: for (int i = 0; i < regCnt; i++) {
>> 1283: // FIXME: replace with void evmovdqul(Address dst, KRegister
>> mask, XMMRegister src, bool merge, int vector_len);?
>
> Is the fixme a leftover?
Yes. Removed. (I think I was considering merging this instruction with the
storeXmm, but there really isnt a good way to do that)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28136#discussion_r2548005781
