On Tue, 14 Apr 2026 11:33:40 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> * Improving the coverage of the `DomainKeyStore.java` >> * converting existing tests to junit in order to make logs easier to read >> * Further coverage for `DomainKeyStore.java` would be required, but should >> be done as a separate [ticket](https://bugs.openjdk.org/browse/JDK-8382096) >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > 8375322: Improve DomainKeyStore.java coverage Looks good; one minor comment test/jdk/sun/security/provider/KeyStore/DKSTest.java line 248: > 246: > 247: @Test > 248: public void keystoreIsKeyEntryTest() throws Exception { prefacing every test name with "keystore" is probably unnecessary since the whole file is keystore tests. Also, it makes it sound like you're testing whether or not a keystore is a "key entry" which sounds strange. ------------- PR Review: https://git.openjdk.org/jdk/pull/30712#pullrequestreview-4380985289 PR Review Comment: https://git.openjdk.org/jdk/pull/30712#discussion_r3317801958
