On Tue, 13 Oct 2026 17:27:46 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> * Improving the coverage of the `DomainKeyStore.java` >> * converting existing tests to junit in order to make logs easier to read >> * Further coverage for `DomainKeyStore.java` would be required, but should >> be done as a separate [ticket](https://bugs.openjdk.org/browse/JDK-8382096) >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > Change capital S to s A few more minor comments. test/jdk/sun/security/provider/KeyStore/DKSSystemPropertiesTest.java line 92: > 90: if (!keystore.getCreationDate(alias).equals( > 91: Date.from(keystore.getCreationInstant(alias))) > 92: ) { kind of strange to put this on a new line test/jdk/sun/security/provider/KeyStore/DKSTest.java line 78: > 76: private static final char[] KEYSTORE_PASSWORD = > "test123".toCharArray(); > 77: private static final Map<String, KeyStore.ProtectionParameter> > PASSWORDS = > 78: new HashMap<>() {{ The indents here and the next couple methods look twice as big as they should be. test/jdk/sun/security/provider/KeyStore/DKSTest.java line 180: > 178: > 179: URI config = new URI(CONFIG + "#keystores"); > 180: int expected = 2 + 1 + 1; why not just `int expected = 4;`? test/jdk/sun/security/provider/KeyStore/DKSTest.java line 224: > 222: (SecretKey) dks.getKey("firstPkcs12 alias1", > 223: KEYSTORE_PASSWORD); > 224: assertNotNull(actual); these tests with multiple asserts may be easier to troubleshoot if they have a message to go with them. ------------- PR Review: https://git.openjdk.org/jdk/pull/30712#pullrequestreview-5507529270 PR Review Comment: https://git.openjdk.org/jdk/pull/30712#discussion_r4261990607 PR Review Comment: https://git.openjdk.org/jdk/pull/30712#discussion_r4261935836 PR Review Comment: https://git.openjdk.org/jdk/pull/30712#discussion_r4261940119 PR Review Comment: https://git.openjdk.org/jdk/pull/30712#discussion_r4261964841
