On Mon, 26 Oct 2026 22:05:43 GMT, Mikhail Yankelevich
<[email protected]> wrote:
>> test/jdk/sun/security/provider/KeyStore/DKSSystemPropertiesTest.java line 92:
>>
>>> 90: if (!keystore.getCreationDate(alias).equals(
>>> 91: Date.from(keystore.getCreationInstant(alias)))
>>> 92: ) {
>>
>> kind of strange to put this on a new line
>
> It's quite hard for me personally to detact may `)` next to each other and I
> know I'm not the only one. So I'm doing this so it's always easy to read at a
> glance
In terms of readability, breaking up the `if` block would be better:
Date keystoreCreation = Date.from(keystore.getCreationInstant(alias));
if (!keystore.getCreationDate(alias).equals(keystoreCreation)) {
}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30712#discussion_r4388319526
