On Tue, 13 Oct 2026 17:33:18 GMT, Matthew Donovan <[email protected]> wrote:

>> Mikhail Yankelevich has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Change capital S to s
>
> test/jdk/sun/security/provider/KeyStore/DKSTest.java line 78:
> 
>> 76:     private static final char[] KEYSTORE_PASSWORD = 
>> "test123".toCharArray();
>> 77:     private static final Map<String, KeyStore.ProtectionParameter> 
>> PASSWORDS =
>> 78:             new HashMap<>() {{
> 
> The indents here and the next couple methods look twice as big as they should 
> be.

fixed in the next commit

> test/jdk/sun/security/provider/KeyStore/DKSTest.java line 180:
> 
>> 178: 
>> 179:         URI config = new URI(CONFIG + "#keystores");
>> 180:         int expected = 2 + 1 + 1;
> 
> why not just `int expected = 4;`?

Good point

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30712#discussion_r4578430215
PR Review Comment: https://git.openjdk.org/jdk/pull/30712#discussion_r4578429370

Reply via email to