On Thu, 20 Aug 2026 08:07:52 GMT, Shawn Emery <[email protected]> wrote:
>> This enhancement provides AArch64 GPR intrinsics for doubleKeccak(). >> Previously, only SIMD (Neon) intrinsics were implemented for doubleKeccak() >> on AArch64 systems. Performance gains for ML-KEM and ML-DSA benchmarks >> improve from 2 to 9% with the GPR intrinsics: >> >> ML-KEM decapsulation: +2-6% ops/sec >> ML-KEM encapsulation: +3-8% ops/sec >> ML-KEM key generation: +4-6% ops/sec >> >> ML-DSA signing: +2-4% ops/sec >> ML-DSA verification: +6-9% ops/sec >> ML-DSA key generation: +6-8% ops/sec >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Shawn Emery has updated the pull request incrementally with one additional > commit since the last revision: > > Implement more comments from theRealAph and adinn src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5115: > 5113: #ifndef R18_RESERVED > 5114: can_use_r18 = true; > 5115: #endif Suggestion: const bool can_use_r18 = R18_RESERVED_ONLY(false) NOT_R18_RESERVED(true); src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5169: > 5167: __ pop(saved_regs, sp); > 5168: if (can_use_fp && can_use_r18) { > 5169: __ ldr(r18_tls, Address(sp, 96)); Suggestion: __ ldr(r18_tls, Address(sp, something * wordSize)); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32049#discussion_r3829884938 PR Review Comment: https://git.openjdk.org/jdk/pull/32049#discussion_r3829907600
