On Sat, 22 Aug 2026 10:39:22 GMT, Andrew Haley <[email protected]> wrote:
> > > I think we might be able to get rid of all the `can_use_r18` crud because > > > `lr` is free. > > > > > > `lr` is used as the round constant (`rc`) by `keccak_round_gpr`. > > Oh, I see it now! That took a while. `lr` is aliased as `r30`. I never > imagined anyone would do that. > > This function is a mass of confusing and risky traps. The aliasing of `a4` > and `a9` is nasty, but disguising the clobber of `lr` by calling it `r30` is > dreadful. Perhaps we can address this is another bug? I'm starting to get a little nervous of the unrelated changes to the double-Keccak GPR feature. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32049#issuecomment-5405088670
