On Tue, 18 Aug 2026 18:33:49 GMT, Sean Mullan <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> import cleanup.
>
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 221:
>
>> 219: * @return this builder
>> 220: * @throws IllegalArgumentException if {@code p} is not
>> positive,
>> 221: * greater than {@code 16777215}, or greater than
>> {@code m / 8}
>
> I think it would be useful to note that 16777215 is also 2^(24)-1 per the
> Argon2 RFC.
Ok.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4203985014