On Fri, 14 Aug 2026 04:23:51 GMT, Bernd <[email protected]> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   import cleanup.
>
> src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 205:
> 
>> 203:         void fillMemoryBlocks() {
>> 204:             int poolSize = Math.min(lanes,
>> 205:                     Runtime.getRuntime().availableProcessors());
> 
> Should it allow to specify a Max or maybe never max out on all CPU Cores? For 
> concurrent services or for example CPU Limited Kubernetes pods this is 
> deadly, Not to mention the possible dos a brute force attacker could Provoke. 
> In an App I would use a Single Pool Limited to a Fraktion of the CPUs. (Maybe 
> its not so bad if the lane Parameter is used responsible?)
> Also cam the threads get a name please

Hmm, with this concern and to make matters simpler, I've reverted to just do 
the task on the calling thread and not create worker threads on this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4201354755

Reply via email to