On Wed, 7 Oct 2026 18:08:31 GMT, Valerie Peng <[email protected]> wrote:
>> Initial commit containing the public API changes and related regression >> tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Valerie Peng has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed sample code in class javadoc and minor fix. src/java.base/share/classes/com/sun/crypto/provider/Argon2DerivedKey.java line 45: > 43: /** > 44: * This class represents a secret key derived using Argon2 whose > toString() > 45: * method outputs Argon2 encoded hash. `toString` no longer outputs the hash. src/java.base/share/classes/com/sun/crypto/provider/Argon2DerivedKey.java line 147: > 145: } catch (RuntimeException re) { > 146: // if cannot compare for any reason > 147: return false; So if `that` is destroyed, `false` is returned. So of one key is destroyed, `k1.equals(k2)` is not the same as `k2.equals(k1)`. src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line 188: > 186: > 187: // return the ceiling of log2 value > 188: private static int ceilingOfLog2(int n) { Useless now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4222723430 PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4222776091 PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4222851119
