On Thu, 8 Oct 2026 18:36:16 GMT, Weijun Wang <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed sample code in class javadoc and minor fix.
>
> src/java.base/share/classes/com/sun/crypto/provider/Argon2DerivedKey.java
> line 147:
>
>> 145: } catch (RuntimeException re) {
>> 146: // if cannot compare for any reason
>> 147: return false;
>
> So if `that` is destroyed, `false` is returned. So of one key is destroyed,
> `k1.equals(k2)` is not the same as `k2.equals(k1)`.
Good point, will fix.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4225687668
