On Thu, 8 Oct 2026 18:30:36 GMT, Weijun Wang <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed sample code in class javadoc and minor fix.
>
> src/java.base/share/classes/com/sun/crypto/provider/Argon2DerivedKey.java
> line 45:
>
>> 43: /**
>> 44: * This class represents a secret key derived using Argon2 whose
>> toString()
>> 45: * method outputs Argon2 encoded hash.
>
> `toString` no longer outputs the hash.
Yes, good catch. Will fix.
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 188:
>
>> 186:
>> 187: // return the ceiling of log2 value
>> 188: private static int ceilingOfLog2(int n) {
>
> Useless now.
Yes, removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4225089450
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4225094051
