Nils Goroll wrote:
> please review my suggested fix for
> http://defect.opensolaris.org/bz/show_bug.cgi?id=3093
> available at
> http://cr.opensolaris.org/~nigoroll/defect_3093_pam_unix_cred/
Keep in mind that pathconf() isn't guaranteed to set errno to 0 in the
situation you're checking for. Rather, it leaves errno unchanged. That
means you need to set errno = 0 before you call pathconf(), and I don't
see code to do that here.
>
> This is my first review request, but if I got this right, the timeout for
> one-liners is two days, right? If yes, Timeout would be August 29
I don't know what you mean. All changes (one-liners included) require
code review. Whether that takes minutes, days, or years depends on your
ability to find responsive reviewers.
It's perfectly fine for you to offer some minimum amount of time for
members of an alias like this one to review what you've done. But
there's no timeout mechanism that lets you commit unreviewed code if no
one responds.
Scott
