Hi Scott and all,

> Keep in mind that pathconf() isn't guaranteed to set errno to 0

thanks a lot, incredible that I did not get that tiny change right from the 
start.

Could I ask everyone to please review the round two webrev?

http://cr.opensolaris.org/~nigoroll/defect_3093_pam_unix_cred-rd2/

I have re-run my tests with the fix and documented them in the bug:

http://defect.opensolaris.org/bz/show_bug.cgi?id=3093


>> This is my first review request, but if I got this right, the timeout for
>> one-liners is two days, right? If yes, Timeout would be August 29
> 
> I don't know what you mean. All changes (one-liners included) require 
> code review. Whether that takes minutes, days, or years depends on your 
> ability to find responsive reviewers.

Thank you for making the process very clear, I was inferring from other code 
review requests that there were standard timeouts, but none of the developer 
faqs I am aware of mention them.

Can anyone provide a pointer to the definition of timeouts for code reviews?

Cheers, Nils
 
 
This message posted from opensolaris.org

Reply via email to