Nils Goroll writes: > James, > > thank you for providing some background on the use of review timeouts. > > I have added this information to > http://www.genunix.org/wiki/index.php/Developer_HOWTO to help other > developers from outside Sun understand what timeouts are all about.
That looks good to me. There are special places where timeouts do matter, but they're constrained to instances where the review has in effect already been done (and none of these apply to code). For instance, the architectural review process includes a "fast-track" mechanism: the text is assumed to have been reviewed by the fast-track sponsor, and is already in a state where it can be approved. The timer is set to allow others to chime in if something was missed, because the ARC is there to give broader exposure. Anyone can say, "hey, wait a minute on this" and slow down the process for adequate review. That doesn't apply for code or design reviews. You need to have the feedback to complete the RTI, even if the only thing the reviewers say is, "looks perfect." (And one hopes they never do that. ;-}) -- James Carlson, Solaris Networking <james.d.carlson at sun.com> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
