Nils Goroll writes: > Thank you for making the process very clear, I was inferring from other code > review requests that there were standard timeouts, but none of the developer > faqs I am aware of mention them. > > Can anyone provide a pointer to the definition of timeouts for code reviews?
No, because there aren't any. It's up to the developer to set a timer (if one is needed at all) based on his judgement of the amount of time necessary to do a thorough review and the capability and other responsibilities of his reviewers. There's nothing formal specified, nor any reason to specify anything. Timers aren't part of the process -- code review *is*. For what it's worth, I usually give at least a week or two, and I tell my reviewers that if they need more time, just let me know. The only important thing I'm defending with the timeout is the estimate of when I'll be done that I provide to my manager ... and I'm usually quite willing to slip that schedule if a reviewer needs more time. -- James Carlson, Solaris Networking <james.d.carlson at sun.com> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
