|
Yes.
That was stupid. :(
Thanks, Chris!
Serguei
On 12/11/17 22:24, Chris Plummer wrote:
That's an internal link. Christoph
won't be able to see them.
Chris
On 12/11/17 9:50 PM, [email protected] wrote:
Hi Christoph,
The fix looks good to me.
I'll submit a mach5 job to make sure nothing is broken.
Thanks,
Serguei
On 12/11/17 07:43, Langer, Christoph wrote:
Hi Serguei, Chris,
please look at
this webrev: http://cr.openjdk.java.net/~clanger/webrevs/8193258.2/
I spotted a few
other locations in libdt_shmem where JDWP HEADER SIZE
should be used. Builds and tests running…
Best regards
Christoph
Hi Serguei,
I wasn’t aware
that the jdk/com/sun/jdi tests would test libjdwp, I
just found hotspot/jtreg/serviceability/jdwp when
searching for jdwp in the tests. But thanks to your
hints I know better now. In fact I ran the jdi tests
when testing my change for 8193183.
I made a new
webrev which includes the removal of inStream_endOfInput:
http://cr.openjdk.java.net/~clanger/webrevs/8193258.1/. Can you
please approve this.
This time I ran
the jdi tests without issues and also did builds on
Windows, linux x86, AIX, Solaris and Mac. J
Best regards
Christoph
Hi Christoph,
You need to run at least the jdk/com/sun/jdi tests.
Thanks,
Serguei
On 12/8/17 13:07, Langer, Christoph wrote:
Hi Serguei,
I did only
run hotspot/jtreg/serviceability/jdwp, didn’t find
a lot more in that area. I’m hoping/waiting for
Chris’ tests then.
I agree, I
will then remove inStream_endOfInput. If something
like that is needed for future developments, it
can easily be added again.
Best regards
Christoph
Hi Christoph,
The fix looks good to me.
What tests did you run?
On 12/8/17 07:07, Langer, Christoph wrote:
I'm inclined to remove it.
Otherwise, it must be:
417 return (stream->left
<= 0);
Thanks,
Serguei
|
