On Thu, 13 Oct 2022 04:06:27 GMT, Ioi Lam <[email protected]> wrote:
> We have code in jdk.internal.jvmstat for supporting an ancient version (JDK
> 1.4.1). There's currently no test case for this code, so it's likely to be
> further bit-rotten in the future. Let's remove it now.
>
> If anyone wants to connect to JDK 1.4.1, they can use tools from JDK 19 or
> earlier.
Looks like a good cleanup. One suggestion/request below if you feel like it.
Thanks.
src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java
line 94:
> 92: } catch (NumberFormatException e) { }
> 93:
> 94: throw new IllegalArgumentException("file name does not match
> pattern");
Pre-existing but it would be nice if this actually reported the file and the
pattern.
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10687
