On Thu, 13 Oct 2022 06:52:43 GMT, David Holmes <[email protected]> wrote:
>> We have code in jdk.internal.jvmstat for supporting an ancient version (JDK
>> 1.4.1). There's currently no test case for this code, so it's likely to be
>> further bit-rotten in the future. Let's remove it now.
>>
>> If anyone wants to connect to JDK 1.4.1, they can use tools from JDK 19 or
>> earlier.
>
> src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java
> line 94:
>
>> 92: } catch (NumberFormatException e) { }
>> 93:
>> 94: throw new IllegalArgumentException("file name does not match
>> pattern");
>
> Pre-existing but it would be nice if this actually reported the file and the
> pattern.
Maybe "cannot convert 'filename' to VM id". (Or to pid.) We just parse it as
an Integer now, so showing the problem filename would be nice. (Not sure if we
would get this far trying a 1.4.1 attach, but if we did, it would help diagnose
that.)
-------------
PR: https://git.openjdk.org/jdk/pull/10687
