On Thu, 13 Oct 2022 04:06:27 GMT, Ioi Lam <[email protected]> wrote: > We have code in jdk.internal.jvmstat for supporting an ancient version (JDK > 1.4.1). There's currently no test case for this code, so it's likely to be > further bit-rotten in the future. Let's remove it now. > > If anyone wants to connect to JDK 1.4.1, they can use tools from JDK 19 or > earlier.
Marked as reviewed by kevinw (Committer). Maybe the 3 classes in src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/v1_0/ are redundant...? We parse a version number in AbstractPerfDataBuffer.createPerfDataBuffer() and create e.g. sun.jvmstat.perfdata.monitor.v2_0.PerfDataBuffer I don't have evidence of exactly where version 2 starts (I know it was in jdk5, but maybe it was 1.4.2), so I'm not saying the removal should be done now. Anyway, looks good. ------------- PR: https://git.openjdk.org/jdk/pull/10687
