On Thu, 27 Feb 2025 18:06:19 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> This change removes the ci, c1 and c2 compiler code from the serviceability >> agent. The ciReplay functionality is supported inside the jvm and this >> duplicated functionality in SA had bit rotted so is removed. >> Tested with tier1-4. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > More friends. src/hotspot/share/runtime/vmStructs.cpp line 706: > 704: volatile_nonstatic_field(MonitorList, _head, > ObjectMonitor*) \ > 705: > \ > 706: unchecked_c2_static_field(Matcher, _regEncode, > sizeof(Matcher::_regEncode)) /* NOTE: no type */ \ I don't see usage in SA of `VMReg::regEncode()` which access this field. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23782#discussion_r1974673849