On Fri, 28 Feb 2025 18:10:26 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> This change removes the ci, c1 and c2 compiler code from the serviceability >> agent. The ciReplay functionality is supported inside the jvm and this >> duplicated functionality in SA had bit rotted so is removed. >> Tested with tier1-4. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > Fix COMPILER2 preprocessor constant for SA. I wonder if you shouldn't use a new CR for this PR to make it clear to anyone that skims over the title of the PR/CR that (broken) functionality is being removed, not fixed. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23782#issuecomment-2691416497
